Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2323973002: Fix tooltip text for ContentSettingImageView. (Closed)

Created:
4 years, 3 months ago by Evan Stade
Modified:
4 years, 3 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix tooltip text for ContentSettingImageView. The image is non-interactive, so it doesn't display the tooltip. Set the tooltip on the ContentSettingImageView instead. BUG=645140 Committed: https://crrev.com/31c20ef1d76caf6e6f1a5489c30ef5136d56cf37 Cr-Commit-Position: refs/heads/master@{#417670}

Patch Set 1 #

Total comments: 2

Patch Set 2 : operator= #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/ui/views/location_bar/content_setting_image_view.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.cc View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
Evan Stade
The image was set to non-interactive in 2013. The content setting tooltip has always been ...
4 years, 3 months ago (2016-09-08 21:45:13 UTC) #3
Peter Kasting
LGTM https://codereview.chromium.org/2323973002/diff/1/chrome/browser/ui/views/location_bar/content_setting_image_view.cc File chrome/browser/ui/views/location_bar/content_setting_image_view.cc (right): https://codereview.chromium.org/2323973002/diff/1/chrome/browser/ui/views/location_bar/content_setting_image_view.cc#newcode152 chrome/browser/ui/views/location_bar/content_setting_image_view.cc:152: tooltip->assign(content_setting_image_model_->get_tooltip()); Nit: Or just *tooltip = content_setting_image_model_->get_tooltip();
4 years, 3 months ago (2016-09-08 21:51:50 UTC) #7
Evan Stade
https://codereview.chromium.org/2323973002/diff/1/chrome/browser/ui/views/location_bar/content_setting_image_view.cc File chrome/browser/ui/views/location_bar/content_setting_image_view.cc (right): https://codereview.chromium.org/2323973002/diff/1/chrome/browser/ui/views/location_bar/content_setting_image_view.cc#newcode152 chrome/browser/ui/views/location_bar/content_setting_image_view.cc:152: tooltip->assign(content_setting_image_model_->get_tooltip()); On 2016/09/08 21:51:50, Peter Kasting wrote: > Nit: ...
4 years, 3 months ago (2016-09-09 18:48:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323973002/20001
4 years, 3 months ago (2016-09-09 18:49:08 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-09 19:36:13 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 19:37:43 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/31c20ef1d76caf6e6f1a5489c30ef5136d56cf37
Cr-Commit-Position: refs/heads/master@{#417670}

Powered by Google App Engine
This is Rietveld 408576698