Fix tooltip text for ContentSettingImageView.

Fix tooltip text for ContentSettingImageView.

The image is non-interactive, so it doesn't display the tooltip. Set the tooltip on the ContentSettingImageView instead.

BUG=645140
Committed: https://crrev.com/31c20ef1d76caf6e6f1a5489c30ef5136d56cf37
Cr-Commit-Position: refs/heads/master@{#417670}

[Evan Stade, 2016-09-08 21:43:55]

Description was changed from

==========
Fix tooltip text for ContentSettingImageView.

BUG=645140
==========

to

==========
Fix tooltip text for ContentSettingImageView.

The image is non-interactive, so it doesn't display the tooltip.

BUG=645140
==========

[Evan Stade, 2016-09-08 21:43:55]

estade@chromium.org changed reviewers:
+ pkasting@chromium.org

[Evan Stade, 2016-09-08 21:45:13]

The image was set to non-interactive in 2013. The content setting tooltip has
always been set on image() and not |this|. This makes me doubt the regression
was a result of MD-related changes. In any case, it's easy enough to fix.

[Evan Stade, 2016-09-08 21:45:34]

Description was changed from

==========
Fix tooltip text for ContentSettingImageView.

The image is non-interactive, so it doesn't display the tooltip.

BUG=645140
==========

to

==========
Fix tooltip text for ContentSettingImageView.

The image is non-interactive, so it doesn't display the tooltip. Set the tooltip
on the ContentSettingImageView instead.

BUG=645140
==========

[Evan Stade, 2016-09-08 21:45:40]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 21:46:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Kasting, 2016-09-08 21:51:50]

LGTM

https://codereview.chromium.org/2323973002/diff/1/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/content_setting_image_view.cc (right):

https://codereview.chromium.org/2323973002/diff/1/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/content_setting_image_view.cc:152:
tooltip->assign(content_setting_image_model_->get_tooltip());
Nit: Or just

  *tooltip = content_setting_image_model_->get_tooltip();

[commit-bot: I haz the power, 2016-09-08 22:45:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 22:45:02]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-09-09 18:48:01]

https://codereview.chromium.org/2323973002/diff/1/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/content_setting_image_view.cc (right):

https://codereview.chromium.org/2323973002/diff/1/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/content_setting_image_view.cc:152:
tooltip->assign(content_setting_image_model_->get_tooltip());
On 2016/09/08 21:51:50, Peter Kasting wrote:
> Nit: Or just
> 
>   *tooltip = content_setting_image_model_->get_tooltip();

Done.

[Evan Stade, 2016-09-09 18:48:46]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-09-09 18:48:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2323973002/#ps20001
(title: "operator=")

[commit-bot: I haz the power, 2016-09-09 18:49:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 19:36:12]

Description was changed from

==========
Fix tooltip text for ContentSettingImageView.

The image is non-interactive, so it doesn't display the tooltip. Set the tooltip
on the ContentSettingImageView instead.

BUG=645140
==========

to

==========
Fix tooltip text for ContentSettingImageView.

The image is non-interactive, so it doesn't display the tooltip. Set the tooltip
on the ContentSettingImageView instead.

BUG=645140
==========

[commit-bot: I haz the power, 2016-09-09 19:36:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-09 19:37:41]

Description was changed from

==========
Fix tooltip text for ContentSettingImageView.

The image is non-interactive, so it doesn't display the tooltip. Set the tooltip
on the ContentSettingImageView instead.

BUG=645140
==========

to

==========
Fix tooltip text for ContentSettingImageView.

The image is non-interactive, so it doesn't display the tooltip. Set the tooltip
on the ContentSettingImageView instead.

BUG=645140

Committed: https://crrev.com/31c20ef1d76caf6e6f1a5489c30ef5136d56cf37
Cr-Commit-Position: refs/heads/master@{#417670}
==========

[commit-bot: I haz the power, 2016-09-09 19:37:43]

Patchset 2 (id:??) landed as
https://crrev.com/31c20ef1d76caf6e6f1a5489c30ef5136d56cf37
Cr-Commit-Position: refs/heads/master@{#417670}