Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Issue 2323953002: [layout-ng] Use correct height for ContainerBlockSize (Closed)

Created:
4 years, 3 months ago by cbiesinger
Modified:
4 years, 3 months ago
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layout-ng] Use correct height for ContainerBlockSize https://codereview.chromium.org/2154593003 added availableLogicalHeightForPercentageComputation, shared with the regular percentage computation code, so this is definitely correct. R=ikilpatrick@chromium.org,eae@chromium.org,glebl@chromium.org BUG=635619 Committed: https://crrev.com/14ce7d174f87288a351c4eee7a511bd7ba526fc9 Cr-Commit-Position: refs/heads/master@{#417427}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
cbiesinger
4 years, 3 months ago (2016-09-08 21:05:24 UTC) #1
Gleb Lanbin
lgtm
4 years, 3 months ago (2016-09-08 21:20:36 UTC) #4
ikilpatrick
lgtm
4 years, 3 months ago (2016-09-08 21:29:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323953002/1
4 years, 3 months ago (2016-09-08 21:42:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 22:58:26 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/14ce7d174f87288a351c4eee7a511bd7ba526fc9 Cr-Commit-Position: refs/heads/master@{#417427}
4 years, 3 months ago (2016-09-08 23:00:12 UTC) #11
eae
4 years, 3 months ago (2016-09-09 10:46:57 UTC) #12
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698