Issue 2323933003: Disable QUIC versions 33 and earlier, protected by FLAGS_quic_disable_pre_34.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2323933003: Disable QUIC versions 33 and earlier, protected by FLAGS_quic_disable_pre_34. (Closed)

Created:
4 years, 3 months ago by ianswett

Modified:
4 years, 3 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable QUIC versions 33 and earlier, protected by FLAGS_quic_disable_pre_34. Merge internal change: 131866795 R=rch@chromium.org BUG=

Patch Set 1 #

Total comments: 1

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+99 lines, -5 lines)			Patch
M	net/quic/core/quic_flags_list.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/core/quic_protocol.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	net/quic/core/quic_protocol.cc	View	3 chunks	+9 lines, -1 line	0 comments	Download
M	net/quic/core/quic_protocol_test.cc	View	1 chunk	+82 lines, -4 lines	1 comment	Download

Depends on Patchset:

Issue 2326723004 Patch 1

Dependent Patchsets:

Issue 2325803002 Patch 1

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

4 years, 3 months ago (2016-09-08 22:39:25 UTC) #3

lgtm

https://codereview.chromium.org/2323933003/diff/1/net/quic/core/quic_protocol...
File net/quic/core/quic_protocol_test.cc (right):

https://codereview.chromium.org/2323933003/diff/1/net/quic/core/quic_protocol...
net/quic/core/quic_protocol_test.cc:303: TEST(QuicProtocolTest,
FilterSupportedVersionsAllVersions) {
Oh, actually, you need a QuicFlagSaver in these new tests.

Expand Messages | Collapse Messages