Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2323913007: Add constructor taking group ID to MediaStreamDevice and StreamDeviceInfo (Closed)

Created:
4 years, 3 months ago by Guido Urdaneta
Modified:
4 years, 3 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, phoglund+watch_chromium.org, posciak+watch_chromium.org, tnakamura+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add constructor taking a group ID to MediaStreamDevice and StreamDeviceInfo. BUG=636300 Committed: https://crrev.com/50eb11b562c9d277ec416899ccb365c04ff295b4 Cr-Commit-Position: refs/heads/master@{#417924}

Patch Set 1 #

Patch Set 2 : Fix constructor #

Messages

Total messages: 27 (19 generated)
Guido Urdaneta
4 years, 3 months ago (2016-09-12 10:00:47 UTC) #10
Max Morin
On 2016/09/12 10:00:47, Guido Urdaneta wrote: Thanks, it's nicer like this. LGTM.
4 years, 3 months ago (2016-09-12 10:29:45 UTC) #11
tommi (sloooow) - chröme
lgtm
4 years, 3 months ago (2016-09-12 12:14:24 UTC) #17
Guido Urdaneta
jochen@chromium.org: Please review changes in content/public
4 years, 3 months ago (2016-09-12 12:15:08 UTC) #19
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-12 12:16:49 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323913007/60001
4 years, 3 months ago (2016-09-12 12:17:37 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 3 months ago (2016-09-12 12:21:22 UTC) #25
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 12:25:21 UTC) #27
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/50eb11b562c9d277ec416899ccb365c04ff295b4
Cr-Commit-Position: refs/heads/master@{#417924}

Powered by Google App Engine
This is Rietveld 408576698