Add simple fuzzer for HttpAuthChallengeTokenizer

Add simple fuzzer for HttpAuthChallengeTokenizer

BUG=599584
Committed: https://crrev.com/88d2a618f14c4f346bce5ea7c74b6c891a0807f7
Cr-Commit-Position: refs/heads/master@{#417609}

[Charlie Harrison, 2016-09-08 20:12:55]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 20:13:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2016-09-08 20:13:45]

csharrison@chromium.org changed reviewers:
+ mmenke@chromium.org

[Charlie Harrison, 2016-09-08 20:13:45]

Hey mmenke do you think this fuzzer is worthwhile on its own? Should we add a
dictionary?

[commit-bot: I haz the power, 2016-09-08 21:45:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 21:45:20]

Dry run: This issue passed the CQ dry run.

[mmenke, 2016-09-09 15:12:12]

mmenke@chromium.org changed reviewers:
+ asanka@chromium.org

[mmenke, 2016-09-09 15:12:12]

[+asanka], who knows auth.

My general feeling is that wherever we have a string tokenizer that takes input
from a non-Chrome-internal source, we should have a fuzzer, so landing this
makes sense, unless we want to test at the net::HttpAuthController layer
instead.

On 2016/09/08 20:13:45, Charlie Harrison wrote:
> Hey mmenke do you think this fuzzer is worthwhile on its own? Should we add a
> dictionary?

[Charlie Harrison, 2016-09-09 15:14:50]

Yeah I was thinking of adding a fuzzer for layers above too (if I have time). I
think it makes sense to fuzz the simplest layer first as it's usually way more
performant (this fuzzer gets 4k execs/s on my machine).

[asanka, 2016-09-09 15:27:29]

Thanks! I'm in favor of this fuzzer.

I'd also like to see some fuzzing at http_auth_controller layer. If you don't
get to it I'll add one. The behavior I'd like to model there is a bit different.
E.g. fuzzing different sequences of challenges possibly with known schemes. I'm
not sure whether the fuzzer will hone in on any interesting individual
challenges at that layer. So fuzzing with random individual challenges is fine
at this layer.

https://codereview.chromium.org/2323913003/diff/20001/net/http/http_auth_chal...
File net/http/http_auth_challenge_tokenizer_fuzzer.cc (right):

https://codereview.chromium.org/2323913003/diff/20001/net/http/http_auth_chal...
net/http/http_auth_challenge_tokenizer_fuzzer.cc:15: }
I'd also call base64_param() on it. There's some logic there as well which could
benefit from fuzzing.

[asanka, 2016-09-09 15:28:26]

Oh and lgtm with the base64_param() call.

[Charlie Harrison, 2016-09-09 15:34:02]

csharrison@chromium.org changed reviewers:
+ mmoroz@chromium.org

[Charlie Harrison, 2016-09-09 15:34:03]

Thanks! Added the base64_param() call.

+mmoroz for added fuzzer.

[mmoroz, 2016-09-09 15:38:50]

LGTM

[mmoroz, 2016-09-09 15:38:52]

LGTM

[Charlie Harrison, 2016-09-09 15:39:10]

The CQ bit was checked by csharrison@chromium.org

[Charlie Harrison, 2016-09-09 15:39:10]

The patchset sent to the CQ was uploaded after l-g-t-m from asanka@chromium.org
Link to the patchset: https://codereview.chromium.org/2323913003/#ps40001
(title: "add base64_param() call")

[commit-bot: I haz the power, 2016-09-09 15:39:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 16:59:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-09 17:02:28]

Description was changed from

==========
Add simple fuzzer for HttpAuthChallengeTokenizer

BUG=599584
==========

to

==========
Add simple fuzzer for HttpAuthChallengeTokenizer

BUG=599584

Committed: https://crrev.com/88d2a618f14c4f346bce5ea7c74b6c891a0807f7
Cr-Commit-Position: refs/heads/master@{#417609}
==========

[commit-bot: I haz the power, 2016-09-09 17:02:29]

Patchset 3 (id:??) landed as
https://crrev.com/88d2a618f14c4f346bce5ea7c74b6c891a0807f7
Cr-Commit-Position: refs/heads/master@{#417609}