Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: ash/accelerators/accelerator_controller_delegate_aura.cc

Issue 2323863002: Separate debugging and developer accelerators (Closed)
Patch Set: Oshima's comments AND Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/accelerators/accelerator_controller_delegate_aura.cc
diff --git a/ash/accelerators/accelerator_controller_delegate_aura.cc b/ash/accelerators/accelerator_controller_delegate_aura.cc
index a87231fe8fed125fc4475a77af0ec9464be153ae..fd18caad3304764a7f342da373b549eecc8edcbe 100644
--- a/ash/accelerators/accelerator_controller_delegate_aura.cc
+++ b/ash/accelerators/accelerator_controller_delegate_aura.cc
@@ -274,7 +274,7 @@ bool AcceleratorControllerDelegateAura::HandlesAction(
// add it to accelerator_controller.cc instead. See class comment.
switch (action) {
case DEBUG_TOGGLE_DEVICE_SCALE_FACTOR:
- case DEBUG_TOGGLE_ROOT_WINDOW_FULL_SCREEN:
+ case DEV_TOGGLE_ROOT_WINDOW_FULL_SCREEN:
oshima 2016/09/15 20:55:52 nit: sort
afakhry 2016/09/15 21:57:40 Done.
case DEBUG_TOGGLE_SHOW_DEBUG_BORDERS:
case DEBUG_TOGGLE_SHOW_FPS_COUNTER:
case DEBUG_TOGGLE_SHOW_PAINT_RECTS:
@@ -294,8 +294,8 @@ bool AcceleratorControllerDelegateAura::HandlesAction(
return true;
#if defined(OS_CHROMEOS)
- case DEBUG_ADD_REMOVE_DISPLAY:
- case DEBUG_TOGGLE_UNIFIED_DESKTOP:
+ case DEV_ADD_REMOVE_DISPLAY:
+ case DEV_TOGGLE_UNIFIED_DESKTOP:
case DISABLE_GPU_WATCHDOG:
case LOCK_PRESSED:
case LOCK_RELEASED:
@@ -321,11 +321,12 @@ bool AcceleratorControllerDelegateAura::CanPerformAction(
const ui::Accelerator& previous_accelerator) {
switch (action) {
case DEBUG_TOGGLE_DEVICE_SCALE_FACTOR:
- case DEBUG_TOGGLE_ROOT_WINDOW_FULL_SCREEN:
case DEBUG_TOGGLE_SHOW_DEBUG_BORDERS:
case DEBUG_TOGGLE_SHOW_FPS_COUNTER:
case DEBUG_TOGGLE_SHOW_PAINT_RECTS:
return debug::DebugAcceleratorsEnabled();
+ case DEV_TOGGLE_ROOT_WINDOW_FULL_SCREEN:
+ return debug::DeveloperAcceleratorsEnabled();
case MAGNIFY_SCREEN_ZOOM_IN:
case MAGNIFY_SCREEN_ZOOM_OUT:
return CanHandleMagnifyScreen();
@@ -346,9 +347,10 @@ bool AcceleratorControllerDelegateAura::CanPerformAction(
return true;
#if defined(OS_CHROMEOS)
- case DEBUG_ADD_REMOVE_DISPLAY:
- case DEBUG_TOGGLE_UNIFIED_DESKTOP:
- return debug::DebugAcceleratorsEnabled();
+ case DEV_ADD_REMOVE_DISPLAY:
+ case DEV_TOGGLE_UNIFIED_DESKTOP:
+ case TOGGLE_MIRROR_MODE:
+ return debug::DeveloperAcceleratorsEnabled();
case SWAP_PRIMARY_DISPLAY:
return display::Screen::GetScreen()->GetNumDisplays() > 1;
@@ -362,7 +364,6 @@ bool AcceleratorControllerDelegateAura::CanPerformAction(
case LOCK_RELEASED:
case POWER_PRESSED:
case POWER_RELEASED:
- case TOGGLE_MIRROR_MODE:
case TOUCH_HUD_PROJECTION_TOGGLE:
return true;
#endif
@@ -381,7 +382,7 @@ void AcceleratorControllerDelegateAura::PerformAction(
case DEBUG_TOGGLE_DEVICE_SCALE_FACTOR:
Shell::GetInstance()->display_manager()->ToggleDisplayScaleFactor();
break;
- case DEBUG_TOGGLE_ROOT_WINDOW_FULL_SCREEN:
+ case DEV_TOGGLE_ROOT_WINDOW_FULL_SCREEN:
oshima 2016/09/15 20:55:53 ditto
afakhry 2016/09/15 21:57:40 Done.
Shell::GetPrimaryRootWindowController()->ash_host()->ToggleFullScreen();
break;
case DEBUG_TOGGLE_SHOW_DEBUG_BORDERS:
@@ -430,10 +431,10 @@ void AcceleratorControllerDelegateAura::PerformAction(
accelerators::Unpin();
break;
#if defined(OS_CHROMEOS)
- case DEBUG_ADD_REMOVE_DISPLAY:
+ case DEV_ADD_REMOVE_DISPLAY:
Shell::GetInstance()->display_manager()->AddRemoveDisplay();
break;
- case DEBUG_TOGGLE_UNIFIED_DESKTOP:
+ case DEV_TOGGLE_UNIFIED_DESKTOP:
Shell::GetInstance()->display_manager()->SetUnifiedDesktopEnabled(
!Shell::GetInstance()->display_manager()->unified_desktop_enabled());
break;
« no previous file with comments | « no previous file | ash/accelerators/accelerator_controller_unittest.cc » ('j') | ash/common/accelerators/accelerator_table.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698