Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2323853002: SVGImageForContainer::imageForCurrentFrame() needs to account for zoom (Closed)

Created:
4 years, 3 months ago by f(malita)
Modified:
4 years, 3 months ago
Reviewers:
davve, fs
CC:
fs, blink-reviews, chromium-reviews, krit, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SVGImageForContainer::imageForCurrentFrame() needs to account for zoom SVGImageForContainer tracks a container zoom factor independently of the actual container size. This zoom factor needs to be accounted for in imageForCurrentFrame() -- otherwise we end up producing an SkImage with a different size than reported by SVGImageForContainer::size(). The easiest way to accomplish this is to use size() when calling SVGImage::imageForCurrentFrameForContainer(), instead of the unzoomed m_containerSize. BUG=643623 R=fs@opera.com,davve@opera.com Committed: https://crrev.com/8e62373579cf6eddb6723e7e8e39306cde20c934 Cr-Commit-Position: refs/heads/master@{#417504}

Patch Set 1 #

Patch Set 2 : expectations #

Messages

Total messages: 23 (13 generated)
f(malita)
4 years, 3 months ago (2016-09-08 19:49:01 UTC) #7
fs
LGTM What does the TC look like before the fix?
4 years, 3 months ago (2016-09-08 20:08:14 UTC) #8
f(malita)
On 2016/09/08 20:08:14, fs wrote: > LGTM > > What does the TC look like ...
4 years, 3 months ago (2016-09-08 20:15:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323853002/20001
4 years, 3 months ago (2016-09-08 20:20:33 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/255863)
4 years, 3 months ago (2016-09-08 20:24:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323853002/20001
4 years, 3 months ago (2016-09-08 20:36:30 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/289915)
4 years, 3 months ago (2016-09-08 23:06:02 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323853002/20001
4 years, 3 months ago (2016-09-09 00:58:24 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-09 04:34:24 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 04:37:00 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e62373579cf6eddb6723e7e8e39306cde20c934
Cr-Commit-Position: refs/heads/master@{#417504}

Powered by Google App Engine
This is Rietveld 408576698