Add action for each button on opt-in IME menu.

chrome/browser/chromeos/input_method/input_method_manager_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/input_method/input_method_manager_impl.h"
 
 #include <stdint.h>
 
 #include <algorithm>  // std::find
 #include <memory>
 #include <set>
 #include <sstream>
 #include <utility>
 
+#include "ash/shell.h"
 #include "base/bind.h"
+#include "base/feature_list.h"
 #include "base/hash.h"
 #include "base/location.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/metrics/sparse_histogram.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/sys_info.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/input_method/candidate_window_controller.h"
 #include "chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.h"
 #include "chrome/browser/chromeos/input_method/input_method_switch_recorder.h"
 #include "chrome/browser/chromeos/language_preferences.h"
 #include "chrome/browser/chromeos/login/session/user_session_manager.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/ash/ash_util.h"
+#include "chrome/common/chrome_features.h"
 #include "chrome/common/pref_names.h"
 #include "components/prefs/pref_service.h"
 #include "components/user_manager/user_manager.h"
 #include "third_party/icu/source/common/unicode/uloc.h"
 #include "ui/base/accelerators/accelerator.h"
 #include "ui/base/ime/chromeos/component_extension_ime_manager.h"
 #include "ui/base/ime/chromeos/extension_ime_util.h"
 #include "ui/base/ime/chromeos/fake_ime_keyboard.h"
 #include "ui/base/ime/chromeos/ime_keyboard.h"
 #include "ui/base/ime/chromeos/input_method_delegate.h"
@@ skipping 1163 matching lines @@
   if (is_ime_menu_activated_ == state_->menu_activated)
     return;
 
   is_ime_menu_activated_ = state_->menu_activated;
   FOR_EACH_OBSERVER(InputMethodManager::ImeMenuObserver, ime_menu_observers_,
                     ImeMenuActivationChanged(is_ime_menu_activated_));
   UMA_HISTOGRAM_BOOLEAN("InputMethod.ImeMenu.ActivationChanged",
                         is_ime_menu_activated_);
 }
 
+void InputMethodManagerImpl::ShowInputViewWithKeyset(
+    const std::string& keyset) {
+  std::string overriden_url = keyboard::GetOverrideContentUrl().spec();

[James Cook, 2016/09/12 17:05:56]

nit: overriden -> overridden 

[Azure Wei, 2016/09/14 06:53:28]

Done.

+
+  auto i = overriden_url.find("#id");

[James Cook, 2016/09/12 17:05:57]

Parsing URLs as strings is discouraged. Is there a way to do this with GURL or
other URL utilities?

[Azure Wei, 2016/09/14 06:53:28]

Updated with using ReplaceComponents(), it this better?

[James Cook, 2016/09/14 21:14:27]

Yes, thanks.

+  // If fails to find "#id", it means the current IME is not system IME, and we
+  // don't support show e/v/h input for such IME extension.
+  if (i == std::string::npos) {

[James Cook, 2016/09/12 17:05:56]

nit: no need for {} for single-line if

[Azure Wei, 2016/09/14 06:53:28]

Done.

+    return;
+  }
+
+  // For system IME exension, the input view url is overriden as:
+  // chrome-extension://${extension_id}/inputview.html#id=us.compact.qwerty
+  // &language=en-US&passwordLayout=us.compact.qwerty&name=keyboard_us
+  // We should replace the id=${keyset} part with desired keyset.
+  auto j = overriden_url.find("&", i + 1);
+  overriden_url.replace(i, j - i, "#id=" + keyset);
+
+  keyboard::SetOverrideContentUrl(GURL(overriden_url));
+
+  keyboard::KeyboardController* keyboard_controller =
+      keyboard::KeyboardController::GetInstance();
+  if (keyboard_controller) {
+    keyboard_controller->ShowKeyboard(false);
+    return;
+  }
+
+  if (keyboard::IsKeyboardEnabled())
+    return;
+
+  // Forcibly enables the a11y onscreen keyboard if there is on keyboard enabled
+  // for now. And re-disables it after showing once.
+  keyboard::SetAccessibilityKeyboardEnabled(true);
+  ash::Shell::GetInstance()->CreateKeyboard();
+  keyboard_controller = keyboard::KeyboardController::GetInstance();
+  if (!keyboard_controller) {
+    keyboard::SetAccessibilityKeyboardEnabled(false);
+  }
+  keyboard_controller->ShowKeyboard(false);
+  keyboard::SetAccessibilityKeyboardEnabled(false);

[James Cook, 2016/09/12 17:05:57]

Does it matter if the accessibilitykeyboard was enabled before this function was
called?

[Azure Wei, 2016/09/14 06:53:28]

Updated this logic.

+}

[James Cook, 2016/09/12 17:05:56]

I don't know the virtual keyboard code very well, but this function seems odd.
There's a bunch of repeated enable/disable going on. I think this needs better
comments explaining what you are doing and why.

This also needs a test, especially given that you are manipulating URLs and
keyboard state.

[Azure Wei, 2016/09/14 06:53:28]

Updated.

Also added tests:
InputMethodManagerImplTest.OverrideKeyboardRefWithEmoji
ImeMenuTrayTest.ShowEmojiKeyset
ImeMenuTrayTest.ForceToShowEmojiKeyset

+
+bool InputMethodManagerImpl::IsEHVInputOnImeMenuEnabled() {
+  return base::FeatureList::IsEnabled(features::kEHVInputOnImeMenu);

[James Cook, 2016/09/12 17:05:56]

FYI, I think the comment on kENVInputOnImeMenu in chrome_features.cc is wrong

https://cs.chromium.org/chromium/src/chrome/common/chrome_features.cc?q=kEHVI...

[Azure Wei, 2016/09/14 06:53:28]

Updated.

+}
+
 }  // namespace input_method
 }  // namespace chromeos