|
|
DescriptionA child profile can also be locked. The child and the locked indicators were not being displayed correctly when appeared together.
http://imgur.com/a/5PyYl
BUG=644836
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/7420824b2840cb3da42196c593509fd65c5518d5
Cr-Commit-Position: refs/heads/master@{#417425}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Addressed comment #Messages
Total messages: 23 (15 generated)
Description was changed from ========== MD User Manager: Displays indicators properly when a pod is both child and locked. BUG=644836 ========== to ========== MD User Manager: Displays indicators properly when a pod is both child and locked. BUG=644836 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== MD User Manager: Displays indicators properly when a pod is both child and locked. BUG=644836 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== a child profile can also be locked. the child and locked indicators were not being displayed correctly before. http://imgur.com/a/5PyYl BUG=644836 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
mahmadi@chromium.org changed reviewers: + michaelpg@chromium.org
Description was changed from ========== a child profile can also be locked. the child and locked indicators were not being displayed correctly before. http://imgur.com/a/5PyYl BUG=644836 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== A child profile can also be locked. The child and the locked indicators were not being displayed correctly when appeared together. http://imgur.com/a/5PyYl BUG=644836 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Hi Michael, Please take a look at this CL.
https://codereview.chromium.org/2323813002/diff/1/chrome/browser/resources/md... File chrome/browser/resources/md_user_manager/user_manager.html (right): https://codereview.chromium.org/2323813002/diff/1/chrome/browser/resources/md... chrome/browser/resources/md_user_manager/user_manager.html:155: height: 100%; remove
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run
https://codereview.chromium.org/2323813002/diff/1/chrome/browser/resources/md... File chrome/browser/resources/md_user_manager/user_manager.html (right): https://codereview.chromium.org/2323813002/diff/1/chrome/browser/resources/md... chrome/browser/resources/md_user_manager/user_manager.html:155: height: 100%; On 2016/09/08 16:27:51, michaelpg wrote: > remove oops... done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
On 2016/09/08 22:35:36, michaelpg wrote: > lgtm Thanks.
The CQ bit was checked by mahmadi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== A child profile can also be locked. The child and the locked indicators were not being displayed correctly when appeared together. http://imgur.com/a/5PyYl BUG=644836 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== A child profile can also be locked. The child and the locked indicators were not being displayed correctly when appeared together. http://imgur.com/a/5PyYl BUG=644836 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== A child profile can also be locked. The child and the locked indicators were not being displayed correctly when appeared together. http://imgur.com/a/5PyYl BUG=644836 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== A child profile can also be locked. The child and the locked indicators were not being displayed correctly when appeared together. http://imgur.com/a/5PyYl BUG=644836 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/7420824b2840cb3da42196c593509fd65c5518d5 Cr-Commit-Position: refs/heads/master@{#417425} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7420824b2840cb3da42196c593509fd65c5518d5 Cr-Commit-Position: refs/heads/master@{#417425} |