Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2323813002: MD User Manager: Displays indicators properly when a pod is both child and locked. (Closed)

Created:
4 years, 3 months ago by Moe
Modified:
4 years, 3 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

A child profile can also be locked. The child and the locked indicators were not being displayed correctly when appeared together. http://imgur.com/a/5PyYl BUG=644836 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/7420824b2840cb3da42196c593509fd65c5518d5 Cr-Commit-Position: refs/heads/master@{#417425}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chrome/browser/resources/md_user_manager/user_manager.html View 1 3 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
Moe
Hi Michael, Please take a look at this CL.
4 years, 3 months ago (2016-09-08 15:47:19 UTC) #7
michaelpg
https://codereview.chromium.org/2323813002/diff/1/chrome/browser/resources/md_user_manager/user_manager.html File chrome/browser/resources/md_user_manager/user_manager.html (right): https://codereview.chromium.org/2323813002/diff/1/chrome/browser/resources/md_user_manager/user_manager.html#newcode155 chrome/browser/resources/md_user_manager/user_manager.html:155: height: 100%; remove
4 years, 3 months ago (2016-09-08 16:27:51 UTC) #8
Moe
https://codereview.chromium.org/2323813002/diff/1/chrome/browser/resources/md_user_manager/user_manager.html File chrome/browser/resources/md_user_manager/user_manager.html (right): https://codereview.chromium.org/2323813002/diff/1/chrome/browser/resources/md_user_manager/user_manager.html#newcode155 chrome/browser/resources/md_user_manager/user_manager.html:155: height: 100%; On 2016/09/08 16:27:51, michaelpg wrote: > remove ...
4 years, 3 months ago (2016-09-08 17:15:57 UTC) #12
michaelpg
lgtm
4 years, 3 months ago (2016-09-08 22:35:36 UTC) #16
Moe
On 2016/09/08 22:35:36, michaelpg wrote: > lgtm Thanks.
4 years, 3 months ago (2016-09-08 22:45:31 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323813002/20001
4 years, 3 months ago (2016-09-08 22:46:19 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-08 22:52:41 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 22:56:28 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7420824b2840cb3da42196c593509fd65c5518d5
Cr-Commit-Position: refs/heads/master@{#417425}

Powered by Google App Engine
This is Rietveld 408576698