sync: Remove ModelTypeInvalidationMap

sync/internal_api/public/base/model_type_test_util.cc

Index: sync/internal_api/public/base/model_type_test_util.cc
diff --git a/sync/internal_api/public/base/model_type_test_util.cc b/sync/internal_api/public/base/model_type_test_util.cc
index 8c1164bec2bf0246815d2a0ca6249b2337c1e2ba..733a64cb710a5ad0f9a5dd56d1ff83d35cd246ef 100644
--- a/sync/internal_api/public/base/model_type_test_util.cc
+++ b/sync/internal_api/public/base/model_type_test_util.cc
@@ -6,6 +6,22 @@
 
 namespace syncer {
 
+ObjectIdInvalidationMap BuildInvalidationMap(
+    ModelType type,
+    int version,
+    const std::string& payload) {
+  ObjectIdInvalidationMap map;
+  invalidation::ObjectId id;
+  Invalidation invalidation;
+
+  DCHECK(RealModelTypeToObjectId(type, &id));

[tim (not reviewing), 2013/08/28 00:13:00]

You shouldn't put "real code" inside DCHECKs like this (assuming you want to
init |id| here). This won't be invoked in release mode.

[rlarocque, 2013/08/28 01:00:35]

Thanks for catching this.  It would have taken me a while to diagnose the trybot
failures that would have resulted had this gone through.

+  invalidation.version = version;
+  invalidation.payload = payload;
+
+  map.insert(std::make_pair(id, invalidation));
+  return map;
+}
+
 void PrintTo(ModelTypeSet model_types, ::std::ostream* os) {
   *os << ModelTypeSetToString(model_types);
 }