sync: Remove ModelTypeInvalidationMap

sync/sync.gyp

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
   },
 
   'includes': [
@@ skipping 47 matching lines @@
         # The core sync library.
         {
           'target_name': 'sync_core',
           'type': 'static_library',
           'variables': { 'enable_wexit_time_destructors': 1, },
           'includes': [
             'sync_core.gypi',
           ],
           'dependencies': [
             'sync_proto',
+            'sync_notifier',
           ],
           'export_dependent_settings': [
             'sync_proto',

[Raghu Simha, 2013/08/30 22:12:43]

You will need to add sync_notifier to the export_dependent_settings section too,
because sync/engine/sync_scheduler.h includes
sync/notifier/object_id_invalidation_map.h, and we  want all targets dependent
on sync_core to inherit its dependency on sync_notifier.

OTOH, this won't be necessary if you can get away with forward declaring
ObjectIdInvalidationMap in sync_scheduler.h. See my comment in sync_scheduler.h.

[rlarocque, 2013/08/30 23:28:08]

Done.

[Raghu Simha, 2013/08/30 23:35:50]

nit: In case you haven't already landed this, sync_proto and sync_notifier
aren't alphabetized (here and in the section above).

           ],
         },
 
         # The sync internal API library.
         {
           'target_name': 'sync_internal_api',
           'type': 'static_library',
           'variables': { 'enable_wexit_time_destructors': 1, },
           'includes': [
             'sync_internal_api.gypi',
@@ skipping 11 matching lines @@
 
         # The sync notifications library.
         {
           'target_name': 'sync_notifier',
           'type': 'static_library',
           'variables': { 'enable_wexit_time_destructors': 1, },
           'includes': [
             'sync_notifier.gypi',
           ],
           'dependencies': [
-            'sync_core',
           ],
         },
 
         # The sync protocol buffer library.
         {
           'target_name': 'sync_proto',
           'type': 'static_library',
           'variables': { 'enable_wexit_time_destructors': 1, },
           'includes': [
             'sync_proto.gypi',
@@ skipping 13 matching lines @@
             'sync_core.gypi',
             'sync_internal_api.gypi',
             'sync_notifier.gypi',
             'sync_proto.gypi',
           ],
         },
       ],
     }],
   ],
 }