third_party/WebKit/Source/core/layout/LayoutGrid.h - Issue 2323793002: [css-grid] Allow percentage values for column and row gutters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.h

Issue 2323793002: [css-grid] Allow percentage values for column and row gutters (Closed)

Patch Set: Apply review comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutGrid.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.h b/third_party/WebKit/Source/core/layout/LayoutGrid.h

index c8de593d3335a6b9365e4df5ae3525468e4b4aed..2847078d6ca00f3b8cadac00ce3ff950d1126e8d 100644

--- a/third_party/WebKit/Source/core/layout/LayoutGrid.h

+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.h

@@ -208,8 +208,8 @@ private:

bool tracksAreWiderThanMinTrackBreadth(GridTrackSizingDirection, GridSizingData&);

#endif

- LayoutUnit gridGapForDirection(GridTrackSizingDirection) const;

- LayoutUnit guttersSize(GridTrackSizingDirection, size_t startLine, size_t span) const;

+ LayoutUnit gridGapForDirection(GridTrackSizingDirection, SizingOperation) const;

+ LayoutUnit guttersSize(GridTrackSizingDirection, size_t startLine, size_t span, SizingOperation) const;

size_t gridItemSpan(const LayoutBox&, GridTrackSizingDirection);

bool spanningItemCrossesFlexibleSizedTracks(const GridSpan&, GridTrackSizingDirection, SizingOperation) const;