Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp

Issue 2323683002: [Sensors] Implement sensor data polling (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp
diff --git a/third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp b/third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp
index 023fa933661f83caea7045ecf9a3fa13c641cb6e..0a2de54a5d39548d1269877ab4fd2316438a8523 100644
--- a/third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp
+++ b/third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp
@@ -39,6 +39,7 @@ SensorProviderProxy::~SensorProviderProxy()
DEFINE_TRACE(SensorProviderProxy)
{
+ visitor->trace(m_frame);
visitor->trace(m_sensors);
Supplement<LocalFrame>::trace(visitor);
}
@@ -51,7 +52,7 @@ SensorProxy* SensorProviderProxy::getOrCreateSensor(device::mojom::blink::Sensor
return sensor;
}
- SensorProxy* sensor = new SensorProxy(type, this);
+ SensorProxy* sensor = new SensorProxy(type, m_frame->page(), this);
haraken 2016/09/08 11:07:13 How is this working? It looks like that no one is
Mikhail 2016/09/08 11:24:48 Ah I missed m_frame initialization when split the
m_sensors.add(sensor);
return sensor;

Powered by Google App Engine
This is Rietveld 408576698