Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSVariableParser.cpp

Issue 2323633002: Implement animation tainted custom property values (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSVariableParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSVariableParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSVariableParser.cpp
index 938813f3a932bcc08487df474e1ceec1c40c1e72..1953ae18088b256079c080a4584fa802ba8f4a46 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSVariableParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSVariableParser.cpp
@@ -129,7 +129,8 @@ bool CSSVariableParser::containsValidVariableReferences(
CSSCustomPropertyDeclaration* CSSVariableParser::parseDeclarationValue(
const AtomicString& variableName,
- CSSParserTokenRange range) {
+ CSSParserTokenRange range,
+ bool isAnimationTainted) {
if (range.atEnd())
return nullptr;
@@ -139,16 +140,18 @@ CSSCustomPropertyDeclaration* CSSVariableParser::parseDeclarationValue(
if (type == CSSValueInvalid)
return nullptr;
- if (type == CSSValueInternalVariableValue)
+ if (type == CSSValueInternalVariableValue) {
return CSSCustomPropertyDeclaration::create(
- variableName,
- CSSVariableData::create(range, hasReferences || hasAtApplyRule));
+ variableName, CSSVariableData::create(range, isAnimationTainted,
+ hasReferences || hasAtApplyRule));
+ }
return CSSCustomPropertyDeclaration::create(variableName, type);
}
CSSVariableReferenceValue* CSSVariableParser::parseRegisteredPropertyValue(
CSSParserTokenRange range,
- bool requireVarReference) {
+ bool requireVarReference,
+ bool isAnimationTainted) {
if (range.atEnd())
return nullptr;
@@ -162,7 +165,7 @@ CSSVariableReferenceValue* CSSVariableParser::parseRegisteredPropertyValue(
return nullptr;
// TODO(timloh): Should this be hasReferences || hasAtApplyRule?
return CSSVariableReferenceValue::create(
- CSSVariableData::create(range, hasReferences));
+ CSSVariableData::create(range, isAnimationTainted, hasReferences));
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698