third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp - Issue 2323633002: Implement animation tainted custom property values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Issue 2323633002: Implement animation tainted custom property values (Closed)

Patch Set: bigger fallback value Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

index 5699293aa7e0a0b411da7347ea41060f60caf947..4ccfd399dcfad54edb8e169f084aded5d7b142e2 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

@@ -159,8 +159,9 @@ bool CSSPropertyParser::parseValueStart(CSSPropertyID unresolvedProperty,

}

if (CSSVariableParser::containsValidVariableReferences(originalRange)) {

+ bool isAnimationTainted = false;

CSSVariableReferenceValue* variable = CSSVariableReferenceValue::create(

- CSSVariableData::create(originalRange));

+ CSSVariableData::create(originalRange, isAnimationTainted, true));

if (isShorthand) {

const CSSPendingSubstitutionValue& pendingValue =