third_party/WebKit/LayoutTests/http/tests/fetch/chromium/mime-sniffing.html - Issue 2323623002: Do not sniff mime type for fetch() requests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/fetch/chromium/mime-sniffing.html

Issue 2323623002: Do not sniff mime type for fetch() requests (Closed)

Patch Set: fix Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/browser/loader/resource_dispatcher_host_impl.cc ('k') | third_party/WebKit/LayoutTests/http/tests/fetch/chromium/resources/mime-sniffing.php » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <script src = "/resources/testharness.js"></script>

	3 <script src = "/resources/testharnessreport.js"></script>

	4 <script>

	5 promise_test(() => {

	6 return fetch('/fetch/chromium/resources/mime-sniffing.php').then(res => {

	7 return res.blob();

	8 }).then(blob => {

	9 assert_equals(blob.type, 'unknown/unknown');

	10 });

	11 }, 'Mime sniffing should not run.');

	12 </script>
	mmenke 2016/09/15 15:08:39 Should we do a browser test instead? We don't run Should we do a browser test instead? We don't run layout tests for CLs that change content/, and this is a content/ behavior. yhirano 2016/09/20 12:12:31 I don't have a strong opinion. Should I create con Show quoted text On 2016/09/15 15:08:39, mmenke wrote: > Should we do a browser test instead? We don't run layout tests for CLs that > change content/, and this is a content/ behavior. I don't have a strong opinion. Should I create content/browser/loader/mime_sniffing_resource_handler_browsertest.cc? Just FYI, there are mime sniffing related layout tests in http/tests/security/contentTypeOptions. mmenke 2016/09/20 15:00:57 It looks to me like content/browser/loader/ change Show quoted text On 2016/09/20 12:12:31, yhirano (slow) wrote: > On 2016/09/15 15:08:39, mmenke wrote: > > Should we do a browser test instead? We don't run layout tests for CLs that > > change content/, and this is a content/ behavior. > > I don't have a strong opinion. Should I create > content/browser/loader/mime_sniffing_resource_handler_browsertest.cc? Just FYI, > there are mime sniffing related layout tests in > http/tests/security/contentTypeOptions. It looks to me like content/browser/loader/ changes don't result in webkit_tests being run (See, for instance, the trybjobs on https://codereview.chromium.org/2355703002/). As someone who has often been hit by content/ and net/ changes only breaking webkit tests after commit (Since they aren't run on content/ or net/ changes), I'd just be a lot happier with a browser test for this.
OLD	NEW