Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 2323603002: Convert JumpList to a KeyedService. (Closed)
Patch Set: Remove notification observer and force destruction on UI thread Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 9f30348031768f7792ceca5cf3b555f7f4be4564..73169a2107659457d6a4f2beb56d65a43736684b 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -168,6 +168,7 @@
#if defined(OS_WIN)
#include "base/win/windows_version.h"
#include "chrome/browser/win/jumplist.h"
+#include "chrome/browser/win/jumplist_factory.h"
#include "ui/gfx/color_palette.h"
#include "ui/native_theme/native_theme_dark_win.h"
#include "ui/views/win/scoped_fullscreen_visibility.h"
@@ -466,14 +467,6 @@ BrowserView::~BrowserView() {
browser_->tab_strip_model()->RemoveObserver(this);
-#if defined(OS_WIN)
- // Terminate the jumplist (must be called before browser_->profile() is
- // destroyed.
- if (jumplist_.get()) {
- jumplist_->Terminate();
- }
-#endif
-
extensions::ExtensionCommandsGlobalRegistry* global_registry =
extensions::ExtensionCommandsGlobalRegistry::Get(browser_->profile());
if (global_registry->registry_for_active_window() ==
@@ -2167,7 +2160,7 @@ void BrowserView::LoadingAnimationCallback() {
void BrowserView::OnLoadCompleted() {
#if defined(OS_WIN)
DCHECK(!jumplist_.get());
- jumplist_ = new JumpList(browser_->profile());
+ jumplist_ = JumpListFactory::GetForProfile(browser_->profile());
#endif
}

Powered by Google App Engine
This is Rietveld 408576698