Source/web/ColorChooserPopupUIController.cpp - Issue 23236002: Prepare for color input datalist support on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ColorChooserPopupUIController.cpp

Issue 23236002: Prepare for color input datalist support on Android (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/ColorChooserPopupUIController.cpp

diff --git a/Source/web/ColorChooserPopupUIController.cpp b/Source/web/ColorChooserPopupUIController.cpp

index da018197cf30487fd3b2da4f8a397601ee85a695..f4fcd09c0e9eaea422edf4a860aa3776c9537216 100644

--- a/Source/web/ColorChooserPopupUIController.cpp

+++ b/Source/web/ColorChooserPopupUIController.cpp

@@ -82,10 +82,10 @@ IntSize ColorChooserPopupUIController::contentSize()

void ColorChooserPopupUIController::writeDocument(DocumentWriter& writer)

{

- Vector<Color> suggestions = m_client->suggestions();

+ Vector<ColorSuggestion> suggestions = m_client->suggestions();

Vector<String> suggestionValues;

for (unsigned i = 0; i < suggestions.size(); i++)

- suggestionValues.append(suggestions[i].serialized());

+ suggestionValues.append(suggestions[i].color.serialized());

IntRect anchorRectInScreen = m_chromeClient->rootViewToScreen(m_client->elementRectRelativeToRootView());

PagePopupClient::addString("<!DOCTYPE html><head><meta charset='UTF-8'><style>\n", writer);