Source/web/ColorChooserPopupUIController.cpp - Issue 23236002: Prepare for color input datalist support on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ColorChooserPopupUIController.cpp

Issue 23236002: Prepare for color input datalist support on Android (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed, added color suggestion struct Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/ColorChooserPopupUIController.cpp

diff --git a/Source/web/ColorChooserPopupUIController.cpp b/Source/web/ColorChooserPopupUIController.cpp

index ed2ad855a028872a0b247a84901f289da0b39d0c..2f4a89d117c288b59a0dd0eefe8a1651ba302f45 100644

--- a/Source/web/ColorChooserPopupUIController.cpp

+++ b/Source/web/ColorChooserPopupUIController.cpp

@@ -85,10 +85,10 @@ IntSize ColorChooserPopupUIController::contentSize()

void ColorChooserPopupUIController::writeDocument(DocumentWriter& writer)

{

- Vector<Color> suggestions = m_client->suggestions();

+ Vector<ColorSuggestion> suggestions = m_client->suggestions();

Vector<String> suggestionValues;

for (unsigned i = 0; i < suggestions.size(); i++)

- suggestionValues.append(suggestions[i].serialized());

+ suggestionValues.append(suggestions[i].colorValue.serialized());

IntRect anchorRectInScreen = m_chromeClient->rootViewToScreen(m_client->elementRectRelativeToRootView());

PagePopupClient::addString("<!DOCTYPE html><head><meta charset='UTF-8'><style>\n", writer);