Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1514)

Unified Diff: Source/core/platform/ColorSuggestion.h

Issue 23236002: Prepare for color input datalist support on Android (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/platform/ColorSuggestion.h
diff --git a/Source/bindings/v8/V8DOMActivityLogger.h b/Source/core/platform/ColorSuggestion.h
similarity index 74%
copy from Source/bindings/v8/V8DOMActivityLogger.h
copy to Source/core/platform/ColorSuggestion.h
index 93915a65f2c791225f9f9df01fd86d85b0ee4ea0..e29b524c93a6847ba58d91dcbb5b277cda4912cf 100644
--- a/Source/bindings/v8/V8DOMActivityLogger.h
+++ b/Source/core/platform/ColorSuggestion.h
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2009 Google Inc. All rights reserved.
+ * Copyright 2013 Google Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
@@ -28,21 +28,27 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef V8DOMActivityLogger_h
-#define V8DOMActivityLogger_h
+#ifndef ColorSuggestion_h
+#define ColorSuggestion_h
-#include <v8.h>
+#include "core/platform/graphics/Color.h"
#include "wtf/text/WTFString.h"
namespace WebCore {
-class V8DOMActivityLogger {
-public:
- virtual ~V8DOMActivityLogger() { }
+struct ColorSuggestion {
+ Color valueAsColor;
+ // The value represented as text will be used to add an accessiblity description to the UI.
tkent 2013/08/26 05:34:56 nit: What format does this text in? HTML5 color s
Miguel Garcia 2013/08/27 14:22:52 Can you explain what's the difference between the
+ String valueAsText;
+ String label;
- virtual void log(const String& apiName, int argc, const v8::Handle<v8::Value>* argv, const String& extraInfo) { }
+ ColorSuggestion(const Color& colorValue, const String& textValue, const String& label)
+ : valueAsColor(colorValue)
+ , valueAsText(textValue)
+ , label(label)
+ { }
};
} // namespace WebCore
-#endif // V8DOMActivityLogger_h
+#endif // ColorSuggestion_h

Powered by Google App Engine
This is Rietveld 408576698