Messaging for successful attestation-based enrollment.

Messaging for successful attestation-based enrollment.

Because attestation-based enrollment is automatic, we want the
message in case of sucess to have the following elements:

  1. The domain that the device has been enrolled into.
  2. A note letting the user what to do in case that enrollment is
     unexpected. (E.g. someone just bought a device off eBay.)

BUG=644002
TEST=manual
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Presubmits will be skipped due to http://crbug.com/639691

Committed: https://crrev.com/13f29c23d565456d68d0393cc9d3b5aa9bb32bff
Cr-Commit-Position: refs/heads/master@{#417438}

[The one and only Dr. Crash, 2016-09-08 00:36:54]

Description was changed from

==========
Messaging for successful attestation-based enrollment.

Because attestation-based enrollment is automatic, we want the
message in case of sucess to have the following elements:

  1. The domain that the device has been enrolled into.
  2. A note letting the user what to do in case that enrollment is
     unexpected. (E.g. someone just bought a device off eBay.)

BUG=644002
TEST=manual
==========

to

==========
Messaging for successful attestation-based enrollment.

Because attestation-based enrollment is automatic, we want the
message in case of sucess to have the following elements:

  1. The domain that the device has been enrolled into.
  2. A note letting the user what to do in case that enrollment is
     unexpected. (E.g. someone just bought a device off eBay.)

BUG=644002
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[The one and only Dr. Crash, 2016-09-08 00:41:40]

The CQ bit was checked by drcrash@chromium.org to run a CQ dry run

[The one and only Dr. Crash, 2016-09-08 00:41:59]

drcrash@chromium.org changed reviewers:
+ achuith@chromium.org, xiyuan@chromium.org

[commit-bot: I haz the power, 2016-09-08 00:42:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 00:49:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 00:49:12]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[achuithb, 2016-09-08 02:24:05]

Looks ok to me overall. xiyuan@ may have something to add.

https://codereview.chromium.org/2323593002/diff/1/chrome/app/chromeos_strings...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2323593002/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:6029: If this is unexpected, please contact
support.
This seems vague. Has this been vetted by a PM? I didn't see anything in the
bug.

https://codereview.chromium.org/2323593002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js
(right):

https://codereview.chromium.org/2323593002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js:18: /**
@const */ var STEP_ABE_SUCCESS = 'abe-success';
Do we use ABE elsewhere? Seems confusing. STEP_ATTEST_SUCCESS? It's not perfect
but easier to guess what's going on?

https://codereview.chromium.org/2323593002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
(right):

https://codereview.chromium.org/2323593002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc:101: return
connector->GetEnterpriseDomain();
We're sure this isn't crashy, right?

[The one and only Dr. Crash, 2016-09-08 03:48:19]

https://codereview.chromium.org/2323593002/diff/1/chrome/app/chromeos_strings...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2323593002/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:6029: If this is unexpected, please contact
support.
On 2016/09/08 02:24:05, achuithb wrote:
> This seems vague. Has this been vetted by a PM? I didn't see anything in the
> bug.

This is behind a flag and one of the main reasons I am doing that now is to have
something to show/discuss with PM and UX.

https://codereview.chromium.org/2323593002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js
(right):

https://codereview.chromium.org/2323593002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js:18: /**
@const */ var STEP_ABE_SUCCESS = 'abe-success';
On 2016/09/08 02:24:05, achuithb wrote:
> Do we use ABE elsewhere? Seems confusing. STEP_ATTEST_SUCCESS? It's not
perfect
> but easier to guess what's going on?

Yes, for example in cryptohomed. We only abbreviate it in non-public places. We
could use the product name, zero-touch, instead but we decided to generalize it
earlier on.

https://codereview.chromium.org/2323593002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
(right):

https://codereview.chromium.org/2323593002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc:101: return
connector->GetEnterpriseDomain();
On 2016/09/08 02:24:05, achuithb wrote:
> We're sure this isn't crashy, right?

Pretty sure. If we crash, so will the Gaia screen we stole this from :)

[achuithb, 2016-09-08 04:45:05]

lgtm from me, but please wait for Xiyuan

[The one and only Dr. Crash, 2016-09-08 04:49:42]

Absolutely.

On Sep 7, 2016 9:45 PM, <achuith@chromium.org> wrote:
>
> lgtm from me, but please wait for Xiyuan
>
> https://codereview.chromium.org/2323593002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[The one and only Dr. Crash, 2016-09-08 05:51:45]

The CQ bit was checked by drcrash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 05:52:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 05:57:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 05:57:47]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[The one and only Dr. Crash, 2016-09-08 19:09:10]

Description was changed from

==========
Messaging for successful attestation-based enrollment.

Because attestation-based enrollment is automatic, we want the
message in case of sucess to have the following elements:

  1. The domain that the device has been enrolled into.
  2. A note letting the user what to do in case that enrollment is
     unexpected. (E.g. someone just bought a device off eBay.)

BUG=644002
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Messaging for successful attestation-based enrollment.

Because attestation-based enrollment is automatic, we want the
message in case of sucess to have the following elements:

  1. The domain that the device has been enrolled into.
  2. A note letting the user what to do in case that enrollment is
     unexpected. (E.g. someone just bought a device off eBay.)

BUG=644002
TEST=manual
NOPRESEUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Presubmits will be skipped due to http://crbug.com/639691
==========

[xiyuan, 2016-09-08 19:37:54]

lgtm

https://codereview.chromium.org/2323593002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js
(right):

https://codereview.chromium.org/2323593002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js:259:
showAttestationBasedEnrollmentSuccess: function(enterprise_domain) {
nit: enterprise_domain -> enterpriseDomain

The identifier format is different in javascript per style guide

https://google.github.io/styleguide/javascriptguide.xml?showone=Naming#Naming

[The one and only Dr. Crash, 2016-09-08 21:58:00]

The CQ bit was checked by drcrash@chromium.org

[The one and only Dr. Crash, 2016-09-08 21:58:00]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2323593002/#ps40001
(title: "Changes for JavaScript style.")

[commit-bot: I haz the power, 2016-09-08 21:58:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 22:08:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 22:08:30]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xiyuan, 2016-09-08 22:10:29]

On 2016/09/08 22:08:30, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

We have typo. It should be

NOPRESUBMIT=true


Not NOPRES[E]UBMIT :)

[The one and only Dr. Crash, 2016-09-08 23:10:25]

Description was changed from

==========
Messaging for successful attestation-based enrollment.

Because attestation-based enrollment is automatic, we want the
message in case of sucess to have the following elements:

  1. The domain that the device has been enrolled into.
  2. A note letting the user what to do in case that enrollment is
     unexpected. (E.g. someone just bought a device off eBay.)

BUG=644002
TEST=manual
NOPRESEUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Presubmits will be skipped due to http://crbug.com/639691
==========

to

==========
Messaging for successful attestation-based enrollment.

Because attestation-based enrollment is automatic, we want the
message in case of sucess to have the following elements:

  1. The domain that the device has been enrolled into.
  2. A note letting the user what to do in case that enrollment is
     unexpected. (E.g. someone just bought a device off eBay.)

BUG=644002
TEST=manual
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Presubmits will be skipped due to http://crbug.com/639691
==========

[The one and only Dr. Crash, 2016-09-08 23:10:36]

> Not NOPRES[E]UBMIT :)

Merci !

[The one and only Dr. Crash, 2016-09-08 23:10:45]

The CQ bit was checked by drcrash@chromium.org

[commit-bot: I haz the power, 2016-09-08 23:11:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 23:44:49]

Description was changed from

==========
Messaging for successful attestation-based enrollment.

Because attestation-based enrollment is automatic, we want the
message in case of sucess to have the following elements:

  1. The domain that the device has been enrolled into.
  2. A note letting the user what to do in case that enrollment is
     unexpected. (E.g. someone just bought a device off eBay.)

BUG=644002
TEST=manual
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Presubmits will be skipped due to http://crbug.com/639691
==========

to

==========
Messaging for successful attestation-based enrollment.

Because attestation-based enrollment is automatic, we want the
message in case of sucess to have the following elements:

  1. The domain that the device has been enrolled into.
  2. A note letting the user what to do in case that enrollment is
     unexpected. (E.g. someone just bought a device off eBay.)

BUG=644002
TEST=manual
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Presubmits will be skipped due to http://crbug.com/639691
==========

[commit-bot: I haz the power, 2016-09-08 23:44:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-08 23:47:39]

Description was changed from

==========
Messaging for successful attestation-based enrollment.

Because attestation-based enrollment is automatic, we want the
message in case of sucess to have the following elements:

  1. The domain that the device has been enrolled into.
  2. A note letting the user what to do in case that enrollment is
     unexpected. (E.g. someone just bought a device off eBay.)

BUG=644002
TEST=manual
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Presubmits will be skipped due to http://crbug.com/639691
==========

to

==========
Messaging for successful attestation-based enrollment.

Because attestation-based enrollment is automatic, we want the
message in case of sucess to have the following elements:

  1. The domain that the device has been enrolled into.
  2. A note letting the user what to do in case that enrollment is
     unexpected. (E.g. someone just bought a device off eBay.)

BUG=644002
TEST=manual
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Presubmits will be skipped due to http://crbug.com/639691

Committed: https://crrev.com/13f29c23d565456d68d0393cc9d3b5aa9bb32bff
Cr-Commit-Position: refs/heads/master@{#417438}
==========

[commit-bot: I haz the power, 2016-09-08 23:47:41]

Patchset 3 (id:??) landed as
https://crrev.com/13f29c23d565456d68d0393cc9d3b5aa9bb32bff
Cr-Commit-Position: refs/heads/master@{#417438}