Add a flag to require a user gesture to add an entry to the back/forward list.

Add a flag to require a user gesture to add an entry to the back/forward list.

Can be enabled in about://flags

BUG=638198
Committed: https://crrev.com/5018fe68a2028eace50ee5bad30cc6c688685757
Cr-Commit-Position: refs/heads/master@{#418635}

[Nate Chapin, 2016-09-07 23:35:24]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 23:36:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 23:40:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 23:40:38]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Nate Chapin, 2016-09-08 19:56:35]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 19:57:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 22:03:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 22:03:17]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2016-09-09 23:14:07]

japhet@chromium.org changed reviewers:
+ jochen@chromium.org, ojan@chromium.org

[Nate Chapin, 2016-09-09 23:14:08]

jochen, would you mind reviewing this?
ojan: fyi

This an experiment that is very unlikely to launch as-is. We're looking at
interventions to keep websites from putting spurious and unhelpful entries in
the back/forward list, and this is the most extreme intervention: don't permit a
new back/forward entry if the user hasn't interacted since the last navigation
or history pushState.

My plan would be to let this spend a week or two available behind a flag, let a
few folks use it and see how broken it is, and use that to inform future
intervention ideas. Is that reasonable?

[ojan, 2016-09-09 23:18:23]

l-g-t-m if jochen is happy with the code.

[jochen (gone - plz use gerrit), 2016-09-12 10:46:46]

I can only approve histograms.xml changes for UseCounter additions, so you'll
still need somebody from the metrics team. Rest looks good

[Nate Chapin, 2016-09-12 18:18:05]

japhet@chromium.org changed reviewers:
+ mpearson@chromium.org

[Nate Chapin, 2016-09-12 18:18:05]

mpearson, would you mind reviewing this histograms.xml change?

[Mark P, 2016-09-13 19:00:45]

histograms.xml lgtm

Sorry for the delay.

--mark

[Nate Chapin, 2016-09-13 19:02:06]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2016-09-13 19:02:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 19:06:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 19:06:26]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Nate Chapin, 2016-09-13 22:16:06]

japhet@chromium.org changed reviewers:
+ dcheng@chromium.org

[Nate Chapin, 2016-09-13 22:16:07]

dcheng, are you up for a quick review of
	content/public/common/common_param_traits_macros.h ?

[dcheng, 2016-09-13 22:44:24]

ipc lgtm

[Nate Chapin, 2016-09-13 22:45:12]

The CQ bit was checked by japhet@chromium.org

[Nate Chapin, 2016-09-13 22:45:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
mpearson@chromium.org
Link to the patchset: https://codereview.chromium.org/2323563002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-13 22:46:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 22:56:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 22:56:08]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nate Chapin, 2016-09-13 23:01:00]

jochen@, looks like histograms/ipcs are signed off. You still ok with the
content/ changes?

[jochen (gone - plz use gerrit), 2016-09-14 08:43:57]

lgtm

[Nate Chapin, 2016-09-14 19:04:05]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2016-09-14 19:04:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 19:14:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-14 19:16:30]

Description was changed from

==========
Add a flag to require a user gesture to add an entry to the back/forward list.

Can be enabled in about://flags

BUG=638198
==========

to

==========
Add a flag to require a user gesture to add an entry to the back/forward list.

Can be enabled in about://flags

BUG=638198

Committed: https://crrev.com/5018fe68a2028eace50ee5bad30cc6c688685757
Cr-Commit-Position: refs/heads/master@{#418635}
==========

[commit-bot: I haz the power, 2016-09-14 19:16:32]

Patchset 3 (id:??) landed as
https://crrev.com/5018fe68a2028eace50ee5bad30cc6c688685757
Cr-Commit-Position: refs/heads/master@{#418635}