Boldly refuse to show rAc dialog if cc info is not requested.

chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h"
 
 #include <algorithm>
 #include <map>
 #include <string>
 
@@ skipping 644 matching lines @@
   // Fail if the author didn't specify autocomplete types.
   if (!has_types) {
     callback_.Run(
         AutofillManagerDelegate::AutocompleteResultErrorUnsupported,
         base::ASCIIToUTF16("Form is missing autocomplete attributes."),
         NULL);
     delete this;
     return;
   }
 
+  // Fail if the author didn't ask for at least some kind of credit card
+  // information.
+  bool has_credit_card_field = false;
+  for (size_t i = 0; i < form_structure_.field_count(); ++i) {
+    AutofillType type = form_structure_.field(i)->Type();
+    if (type.html_type() != HTML_TYPE_UNKNOWN && type.group() == CREDIT_CARD) {
+      has_credit_card_field = true;
+      break;
+    }
+  }
+
+  if (!has_credit_card_field) {
+    callback_.Run(
+        AutofillManagerDelegate::AutocompleteResultErrorUnsupported,
+        base::ASCIIToUTF16("Form is not a payment form (must contain "
+                           "some autocomplete=\"cc-*\" fields). "),
+        NULL);
+    delete this;
+    return;
+  }
+
   billing_country_combobox_model_.reset(new CountryComboboxModel(
       *GetManager(),
       base::Bind(CountryFilter,
                  form_structure_.PossibleValues(ADDRESS_BILLING_COUNTRY))));
   shipping_country_combobox_model_.reset(new CountryComboboxModel(
       *GetManager(),
       base::Bind(CountryFilter,
                  form_structure_.PossibleValues(ADDRESS_HOME_COUNTRY))));
 
   // Log any relevant UI metrics and security exceptions.
@@ skipping 47 matching lines @@
 
   scoped_ptr< ::i18n::addressinput::Downloader> downloader(
       new autofill::ChromeDownloaderImpl(profile_->GetRequestContext()));
   validator_ = AddressValidator::Build(
       downloader.Pass(),
       ValidationRulesStorageFactory::CreateStorage(),
       this);
   GetValidator()->LoadRules(
       GetManager()->GetDefaultCountryCodeForNewAddress());
 
-  // TODO(estade): don't show the dialog if the site didn't specify the right
-  // fields. First we must figure out what the "right" fields are.
   SuggestionsUpdated();
   SubmitButtonDelayBegin();
   view_.reset(CreateView());
   view_->Show();
   GetManager()->AddObserver(this);
 
   if (!account_chooser_model_->WalletIsSelected())
     LogDialogLatencyToShow();
 }
 
@@ skipping 3211 matching lines @@
   view_->UpdateButtonStrip();
 }
 
 void AutofillDialogControllerImpl::FetchWalletCookie() {
   net::URLRequestContextGetter* request_context = profile_->GetRequestContext();
   signin_helper_.reset(new wallet::WalletSigninHelper(this, request_context));
   signin_helper_->StartWalletCookieValueFetch();
 }
 
 }  // namespace autofill