Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2323523003:
Roll mac toolchain to include 10.11. (Closed)
|
Created:
4 years, 3 months ago by justincohen Modified:
4 years, 3 months ago CC:
chromium-reviews, kjellander_chromium, ehmaldonado_chromium Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll mac toolchain to include 10.11.
This is the same as the previous toolchain (Xcode 5.1.1 with 10.10 SDK), but
also includes the 10.11 SDK.
BUG=474373, 626093
Committed: https://crrev.com/37a2442cdac599d971ba961259c78f0c11ab5df1
Cr-Commit-Position: refs/heads/master@{#417392}
Patch Set 1 #Patch Set 2 : Change to kick bots -- to be reverted #Patch Set 3 : Reverted change to kick the bots, back to original CL #
Messages
Total messages: 21 (13 generated)
justincohen@chromium.org changed reviewers: + erikchen@chromium.org
ptal
The CQ bit was checked by justincohen@chromium.org to run a CQ dry run
lgtm can you fill in the BUG field?
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Roll mac toolchain to include 10.11. This is the same as the previous toolchain (Xcode 5.1.1 with 10.10 SDK), but also includes the 10.11 SDK. BUG= ========== to ========== Roll mac toolchain to include 10.11. This is the same as the previous toolchain (Xcode 5.1.1 with 10.10 SDK), but also includes the 10.11 SDK. BUG=474373, 626093 ==========
The CQ bit was unchecked by justincohen@chromium.org
justincohen@chromium.org changed reviewers: + thakis@chromium.org
thakis@ is there a way to force the trybots to actual compile? Right now the analyze step is skipping compile.
The CQ bit was checked by justincohen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by justincohen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from erikchen@chromium.org Link to the patchset: https://codereview.chromium.org/2323523003/#ps40001 (title: "Reverted change to kick the bots, back to original CL")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thakis@chromium.org changed reviewers: + dpranke@chromium.org
dpranke: analyze thinks this mac sdk update is a noop for the bots, while it should really be a full compile. How do we tell analyze that this isn't a noop? justincohen: Is the SDK path part of a compiler commandline or something like that? If not, how are we going to guarantee a clobber build?
Message was sent while issue was closed.
Description was changed from ========== Roll mac toolchain to include 10.11. This is the same as the previous toolchain (Xcode 5.1.1 with 10.10 SDK), but also includes the 10.11 SDK. BUG=474373, 626093 ========== to ========== Roll mac toolchain to include 10.11. This is the same as the previous toolchain (Xcode 5.1.1 with 10.10 SDK), but also includes the 10.11 SDK. BUG=474373, 626093 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Roll mac toolchain to include 10.11. This is the same as the previous toolchain (Xcode 5.1.1 with 10.10 SDK), but also includes the 10.11 SDK. BUG=474373, 626093 ========== to ========== Roll mac toolchain to include 10.11. This is the same as the previous toolchain (Xcode 5.1.1 with 10.10 SDK), but also includes the 10.11 SDK. BUG=474373, 626093 Committed: https://crrev.com/37a2442cdac599d971ba961259c78f0c11ab5df1 Cr-Commit-Position: refs/heads/master@{#417392} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/37a2442cdac599d971ba961259c78f0c11ab5df1 Cr-Commit-Position: refs/heads/master@{#417392}
Message was sent while issue was closed.
On 2016/09/08 20:01:11, Nico wrote: > dpranke: analyze thinks this mac sdk update is a noop for the bots, while it > should really be a full compile. How do we tell analyze that this isn't a noop? You'd either have to add this file to the blacklist in //testing/buildbot/trybot_analyze_config.json, or we'd have to make sure that this is listed as an input/dependency of something in GN that does seem to affect the build. Right now GN knows nothing about this file at all. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
