Remove unused code in CPDFXFA_Document

xfa/fxfa/app/xfa_fftextedit.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxfa/app/xfa_fftextedit.h"
 
 #include <vector>
 
@@ skipping 369 matching lines @@
   m_pDataAcc->ProcessEvent(XFA_ATTRIBUTEENUM_Change, &eParam);
 }
 void CXFA_FFTextEdit::OnTextFull(IFWL_Widget* pWidget) {
   CXFA_EventParam eParam;
   eParam.m_eType = XFA_EVENT_Full;
   eParam.m_pTarget = m_pDataAcc;
   m_pDataAcc->ProcessEvent(XFA_ATTRIBUTEENUM_Full, &eParam);
 }
 
 FX_BOOL CXFA_FFTextEdit::CheckWord(const CFX_ByteStringC& sWord) {
-  if (sWord.IsEmpty() || m_pDataAcc->GetUIType() != XFA_Element::TextEdit) {
+  if (sWord.IsEmpty() || m_pDataAcc->GetUIType() != XFA_Element::TextEdit)
     return TRUE;
-  }
-  return GetDoc()->GetDocProvider()->CheckWord(GetDoc(), sWord);

[Wei Li, 2016/09/13 17:45:52]

I am a bit concerned with changes like this. The underlying problem is the
corresponding implementations CheckWord()/>GetSuggestWords() were not
implemented (simply returns false). I would prefer adding TODO or comments to
state "not implemented" fact. Otherwise, we might escalate removing more
functions as GetSuggestWords() seems always return false.

[dsinclair, 2016/09/13 17:51:19]

I guess the question is, do we know if we'll ever implement these methods? If we
have no plans on implementing them, I think we should remove them (this includes
removing the GetSuggestedWords below since it's always FALSE if it isn't in the
API somewhere).

We can always resurrect the code if we want to bring it back in the future, and
that has the added benefit that we can do a proper code review on it at that
point.

[Wei Li, 2016/09/13 18:09:07]

I am ok with removing unimplemented code. Should we either remove them
completely or correctly mark where they are not implemented (correctly)?
Returning some default values 0 or true/false from some functions in the middle
layer may make code less readable.

[dsinclair, 2016/09/13 18:12:12]

Yea, they should be removed completely. If they're part of the API we should
remove them back to the API entry point and mark that as Not Implemented.

I'll cleanup GetSuggestWords as it's obviously FALSE always, I'm not sure what
to do with CheckWord as it can return both, I'll check the use of the return
value and see what I can figure out.

Will ping when ready.

+  return FALSE;
 }
+
 FX_BOOL CXFA_FFTextEdit::GetSuggestWords(
     const CFX_ByteStringC& sWord,
     std::vector<CFX_ByteString>& sSuggest) {
-  if (m_pDataAcc->GetUIType() != XFA_Element::TextEdit) {
+  if (m_pDataAcc->GetUIType() != XFA_Element::TextEdit)
     return FALSE;
-  }
-  return GetDoc()->GetDocProvider()->GetSuggestWords(GetDoc(), sWord, sSuggest);
+  return FALSE;
 }
 
 void CXFA_FFTextEdit::OnProcessMessage(CFWL_Message* pMessage) {
   m_pOldDelegate->OnProcessMessage(pMessage);
 }
 
 void CXFA_FFTextEdit::OnProcessEvent(CFWL_Event* pEvent) {
   CXFA_FFField::OnProcessEvent(pEvent);
   switch (pEvent->GetClassID()) {
     case CFWL_EventType::TextChanged: {
@@ skipping 380 matching lines @@
 
 void CXFA_FFDateTimeEdit::OnProcessEvent(CFWL_Event* pEvent) {
   if (pEvent->GetClassID() == CFWL_EventType::SelectChanged) {
     CFWL_Event_DtpSelectChanged* event = (CFWL_Event_DtpSelectChanged*)pEvent;
     OnSelectChanged(m_pNormalWidget->GetWidget(), event->iYear, event->iMonth,
                     event->iDay);
     return;
   }
   CXFA_FFTextEdit::OnProcessEvent(pEvent);
 }