Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: fpdfsdk/cpdfsdk_interform.cpp

Issue 2323493002: Pass CFX_WideString further down widget callers (Closed)
Patch Set: Null vs Empty string significant in places Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | fpdfsdk/cpdfsdk_widget.cpp » ('j') | fpdfsdk/cpdfsdk_widget.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/cpdfsdk_interform.cpp
diff --git a/fpdfsdk/cpdfsdk_interform.cpp b/fpdfsdk/cpdfsdk_interform.cpp
index 345487ad498e7df6d640926d4a2653b5fa033212..590b73d283fa814371bf5f142a7642b259aa54bf 100644
--- a/fpdfsdk/cpdfsdk_interform.cpp
+++ b/fpdfsdk/cpdfsdk_interform.cpp
@@ -323,7 +323,7 @@ CFX_WideString CPDFSDK_InterForm::OnFormat(CPDF_FormField* pFormField,
}
void CPDFSDK_InterForm::ResetFieldAppearance(CPDF_FormField* pFormField,
- const FX_WCHAR* sValue,
+ const CFX_WideString* sValue,
FX_BOOL bValueChanged) {
for (int i = 0, sz = pFormField->CountControls(); i < sz; i++) {
CPDF_FormControl* pFormCtrl = pFormField->GetControl(i);
@@ -634,7 +634,7 @@ void CPDFSDK_InterForm::AfterValueChange(CPDF_FormField* pField) {
OnCalculate(pField);
FX_BOOL bFormated = FALSE;
CFX_WideString sValue = OnFormat(pField, bFormated);
- ResetFieldAppearance(pField, bFormated ? sValue.c_str() : nullptr, TRUE);
+ ResetFieldAppearance(pField, bFormated ? &sValue : nullptr, TRUE);
UpdateField(pField);
}
}
« no previous file with comments | « no previous file | fpdfsdk/cpdfsdk_widget.cpp » ('j') | fpdfsdk/cpdfsdk_widget.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698