Pass CFX_WideString further down widget callers

Pass CFX_WideString further down widget callers

Avoid a couple of places where we copy the raw string back into a
brand-new widestring.

There are a few places where the difference between a null
ptr and an empty string control the logic, and I left these
as-is.  Other places can just take the string by const ref.

Committed: https://pdfium.googlesource.com/pdfium/+/a31da74cffa8c3ff919051cc49bc006aeb55d345

[Tom Sepez, 2016-09-07 21:31:34]

Description was changed from

==========
Pass CFX_WideString further down widget callers

Avoid a couple of places where we copy the raw string back into a
brand-new widestring.
==========

to

==========
Pass CFX_WideString further down widget callers

Avoid a couple of places where we copy the raw string back into a
brand-new widestring.

There are a few places where the difference between a null
ptr and an empty string control the logic, and I left these
as-is.  Other places can just take the string by const ref.
==========

[Tom Sepez, 2016-09-07 21:35:23]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 21:35:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-09-07 21:35:39]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-09-07 21:35:40]

Dan, for review.

[commit-bot: I haz the power, 2016-09-07 21:36:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 21:36:42]

Dry run: Try jobs failed on following builders:
  linux_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_no_v8/bui...)
  linux_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa/build...)
  mac_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac_no_v8/build...)

[dsinclair, 2016-09-08 13:00:11]

https://codereview.chromium.org/2323493002/diff/20001/fpdfsdk/cpdfsdk_widget.cpp
File fpdfsdk/cpdfsdk_widget.cpp (right):

https://codereview.chromium.org/2323493002/diff/20001/fpdfsdk/cpdfsdk_widget....
fpdfsdk/cpdfsdk_widget.cpp:1556: sValue = &sValueTmp;
Do we need sValueTmp anymore? If so, can we move the definition inside the if()
as it doesn't appear to be used anywhere else.

https://codereview.chromium.org/2323493002/diff/20001/fpdfsdk/cpdfsdk_widget....
fpdfsdk/cpdfsdk_widget.cpp:1570: nMaxLen = wcslen((const wchar_t*)sValue);
Should this be a .c_str?

https://codereview.chromium.org/2323493002/diff/20001/fpdfsdk/fxedit/fxet_edi...
File fpdfsdk/fxedit/fxet_edit.cpp (right):

https://codereview.chromium.org/2323493002/diff/20001/fpdfsdk/fxedit/fxet_edi...
fpdfsdk/fxedit/fxet_edit.cpp:1673: void CFX_Edit::SetText(const CFX_WideString&
sText) {
May as well leave this as |text| to match the rest of the methods.

https://codereview.chromium.org/2323493002/diff/20001/fpdfsdk/fxedit/fxet_edi...
fpdfsdk/fxedit/fxet_edit.cpp:2886: const CFX_WideString& sText,
ditto

[Tom Sepez, 2016-09-08 18:01:12]

https://codereview.chromium.org/2323493002/diff/20001/fpdfsdk/cpdfsdk_widget.cpp
File fpdfsdk/cpdfsdk_widget.cpp (right):

https://codereview.chromium.org/2323493002/diff/20001/fpdfsdk/cpdfsdk_widget....
fpdfsdk/cpdfsdk_widget.cpp:1556: sValue = &sValueTmp;
On 2016/09/08 13:00:11, dsinclair wrote:
> Do we need sValueTmp anymore? If so, can we move the definition inside the
if()
> as it doesn't appear to be used anywhere else.

No, the argument is a pointer to const, so we can't update the string itself, we
can just make it point to some other string, which itself must live for as long
as we use the pointer.

https://codereview.chromium.org/2323493002/diff/20001/fpdfsdk/cpdfsdk_widget....
fpdfsdk/cpdfsdk_widget.cpp:1570: nMaxLen = wcslen((const wchar_t*)sValue);
No, this should just use the length we already know now that we're passing the
bytestring itself.  Fixed.

https://codereview.chromium.org/2323493002/diff/20001/fpdfsdk/fxedit/fxet_edi...
File fpdfsdk/fxedit/fxet_edit.cpp (right):

https://codereview.chromium.org/2323493002/diff/20001/fpdfsdk/fxedit/fxet_edi...
fpdfsdk/fxedit/fxet_edit.cpp:1673: void CFX_Edit::SetText(const CFX_WideString&
sText) {
On 2016/09/08 13:00:11, dsinclair wrote:
> May as well leave this as |text| to match the rest of the methods.

Fixed the others, too.

https://codereview.chromium.org/2323493002/diff/20001/fpdfsdk/fxedit/fxet_edi...
fpdfsdk/fxedit/fxet_edit.cpp:2886: const CFX_WideString& sText,
On 2016/09/08 13:00:11, dsinclair wrote:
> ditto

Others match this.

[dsinclair, 2016-09-08 18:04:38]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-08 18:04:38]

lgtm

[commit-bot: I haz the power, 2016-09-08 18:04:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 18:28:16]

Description was changed from

==========
Pass CFX_WideString further down widget callers

Avoid a couple of places where we copy the raw string back into a
brand-new widestring.

There are a few places where the difference between a null
ptr and an empty string control the logic, and I left these
as-is.  Other places can just take the string by const ref.
==========

to

==========
Pass CFX_WideString further down widget callers

Avoid a couple of places where we copy the raw string back into a
brand-new widestring.

There are a few places where the difference between a null
ptr and an empty string control the logic, and I left these
as-is.  Other places can just take the string by const ref.

Committed:
https://pdfium.googlesource.com/pdfium/+/a31da74cffa8c3ff919051cc49bc006aeb55...
==========

[commit-bot: I haz the power, 2016-09-08 18:28:17]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/a31da74cffa8c3ff919051cc49bc006aeb55...