Implement new method to get process base address in Windows sandbox.

Implement new method to get process base address in Windows sandbox.
This CL implements a new method of getting the base address of a new
process. It's not clear if the old method of using the thread context is
reliable in the face of third party software, so this implementation
instead uses only documented functionality to acheive the same thing.

BUG=645050
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Committed: https://crrev.com/cd115ae669e4475f9478600506e2130c7dc4b98a
Cr-Commit-Position: refs/heads/master@{#417381}

[forshaw, 2016-09-08 13:34:44]

Description was changed from

==========
Implement new method to get process base address in Windows sandbox.
This CL implements a new method of getting the base address of a new
process. It's not clear if the old method of using the thread context is
reliable in the face of third party software, so this implementation
instead uses only documented functionality to acheive the same thing.

BUG=645050
==========

to

==========
Implement new method to get process base address in Windows sandbox.
This CL implements a new method of getting the base address of a new
process. It's not clear if the old method of using the thread context is
reliable in the face of third party software, so this implementation
instead uses only documented functionality to acheive the same thing.

BUG=645050
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[forshaw, 2016-09-08 16:33:00]

forshaw@chromium.org changed reviewers:
+ wfh@chromium.org

[forshaw, 2016-09-08 16:33:01]

PTAL

[Will Harris, 2016-09-08 16:54:03]

lgtm % comments/nits

https://codereview.chromium.org/2323443003/diff/20001/sandbox/win/src/win_uti...
File sandbox/win/src/win_utils.cc (right):

https://codereview.chromium.org/2323443003/diff/20001/sandbox/win/src/win_uti...
sandbox/win/src/win_utils.cc:457: // This function walks the virtual memory map
using VirtualQueryEx to find
I think some of this comment should be in the .h especially the part about only
using on a suspended process - to avoid people misusing it.

https://codereview.chromium.org/2323443003/diff/20001/sandbox/win/src/win_uti...
sandbox/win/src/win_utils.cc:460: // be used on suspended processes, and ideally
only ones which have not been
can you do some sort of check that the process is suspended and error out?

https://codereview.chromium.org/2323443003/diff/20001/sandbox/win/src/win_uti...
File sandbox/win/src/win_utils_unittest.cc (right):

https://codereview.chromium.org/2323443003/diff/20001/sandbox/win/src/win_uti...
sandbox/win/src/win_utils_unittest.cc:131: class ScopedTerminateProcess {
I wonder if this should be in the anonymous namespace

[forshaw, 2016-09-08 16:57:30]

forshaw@chromium.org changed reviewers:
+ asvitkine@chromium.org

[forshaw, 2016-09-08 16:57:31]

asvitkine@ could you review the minor change to histograms.xml?

[Alexei Svitkine (slow), 2016-09-08 16:58:11]

lgtm

[forshaw, 2016-09-08 17:38:10]

On 2016/09/08 16:58:11, Alexei Svitkine (very slow) wrote:
> lgtm

Thanks very much.

[forshaw, 2016-09-08 17:49:30]

The CQ bit was checked by forshaw@chromium.org

[forshaw, 2016-09-08 17:49:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org, wfh@chromium.org
Link to the patchset: https://codereview.chromium.org/2323443003/#ps60001
(title: "Fix typo")

[commit-bot: I haz the power, 2016-09-08 17:50:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 20:26:18]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-08 20:27:38]

Description was changed from

==========
Implement new method to get process base address in Windows sandbox.
This CL implements a new method of getting the base address of a new
process. It's not clear if the old method of using the thread context is
reliable in the face of third party software, so this implementation
instead uses only documented functionality to acheive the same thing.

BUG=645050
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Implement new method to get process base address in Windows sandbox.
This CL implements a new method of getting the base address of a new
process. It's not clear if the old method of using the thread context is
reliable in the face of third party software, so this implementation
instead uses only documented functionality to acheive the same thing.

BUG=645050
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Committed: https://crrev.com/cd115ae669e4475f9478600506e2130c7dc4b98a
Cr-Commit-Position: refs/heads/master@{#417381}
==========

[commit-bot: I haz the power, 2016-09-08 20:27:40]

Patchset 4 (id:??) landed as
https://crrev.com/cd115ae669e4475f9478600506e2130c7dc4b98a
Cr-Commit-Position: refs/heads/master@{#417381}