Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: content/browser/indexed_db/indexed_db_database.cc

Issue 232343004: Pass blob info through from the IPC to the backing store on put. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix some nits Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_database.cc
diff --git a/content/browser/indexed_db/indexed_db_database.cc b/content/browser/indexed_db/indexed_db_database.cc
index c97048b5612094eb54796602bc067543d9ac3515..644dba0f81f7d44153e73cecfcfccd6b45883133 100644
--- a/content/browser/indexed_db/indexed_db_database.cc
+++ b/content/browser/indexed_db/indexed_db_database.cc
@@ -10,9 +10,11 @@
#include "base/auto_reset.h"
#include "base/logging.h"
#include "base/memory/scoped_ptr.h"
+#include "base/memory/scoped_vector.h"
#include "base/stl_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/utf_string_conversions.h"
+#include "content/browser/indexed_db/indexed_db_blob_info.h"
#include "content/browser/indexed_db/indexed_db_connection.h"
#include "content/browser/indexed_db/indexed_db_context_impl.h"
#include "content/browser/indexed_db/indexed_db_cursor.h"
@@ -25,6 +27,7 @@
#include "content/common/indexed_db/indexed_db_key_path.h"
#include "content/common/indexed_db/indexed_db_key_range.h"
#include "third_party/WebKit/public/platform/WebIDBDatabaseException.h"
+#include "webkit/browser/blob/blob_data_handle.h"
using base::ASCIIToUTF16;
using base::Int64ToString16;
@@ -192,9 +195,7 @@ scoped_ptr<IndexedDBConnection> IndexedDBDatabase::CreateConnection(
scoped_ptr<IndexedDBConnection> connection(
new IndexedDBConnection(this, database_callbacks));
connections_.insert(connection.get());
- /* TODO(ericu): Grant child process permissions here so that the connection
- * can create Blobs.
- */
+ backing_store_->GrantChildProcessPermissions(child_process_id);
return connection.Pass();
}
@@ -702,6 +703,7 @@ struct IndexedDBDatabase::PutOperationParams {
PutOperationParams() {}
int64 object_store_id;
IndexedDBValue value;
+ ScopedVector<webkit_blob::BlobDataHandle> handles;
scoped_ptr<IndexedDBKey> key;
IndexedDBDatabase::PutMode put_mode;
scoped_refptr<IndexedDBCallbacks> callbacks;
@@ -714,6 +716,7 @@ struct IndexedDBDatabase::PutOperationParams {
void IndexedDBDatabase::Put(int64 transaction_id,
int64 object_store_id,
IndexedDBValue* value,
+ ScopedVector<webkit_blob::BlobDataHandle>* handles,
scoped_ptr<IndexedDBKey> key,
PutMode put_mode,
scoped_refptr<IndexedDBCallbacks> callbacks,
@@ -728,9 +731,11 @@ void IndexedDBDatabase::Put(int64 transaction_id,
return;
DCHECK(key);
+ DCHECK(value);
scoped_ptr<PutOperationParams> params(new PutOperationParams());
params->object_store_id = object_store_id;
params->value.swap(*value);
+ params->handles.swap(*handles);
params->key = key.Pass();
params->put_mode = put_mode;
params->callbacks = callbacks;
@@ -830,6 +835,7 @@ void IndexedDBDatabase::PutOperation(scoped_ptr<PutOperationParams> params,
params->object_store_id,
*key,
params->value,
+ &params->handles,
&record_identifier);
if (!s.ok()) {
IndexedDBDatabaseError error(

Powered by Google App Engine
This is Rietveld 408576698