Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Unified Diff: content/renderer/gpu/render_widget_compositor.cc

Issue 2323423002: cc: Add SwapPromiseManager and SurfaceSequenceGenerator. (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/gpu/render_widget_compositor.cc
diff --git a/content/renderer/gpu/render_widget_compositor.cc b/content/renderer/gpu/render_widget_compositor.cc
index 9a797721a07ba2d7258d75accc8c7ac2dcd0dac1..b32ed3299d1fb91303ce3897234fd83da379aea3 100644
--- a/content/renderer/gpu/render_widget_compositor.cc
+++ b/content/renderer/gpu/render_widget_compositor.cc
@@ -41,6 +41,8 @@
#include "cc/trees/latency_info_swap_promise_monitor.h"
#include "cc/trees/layer_tree_host.h"
#include "cc/trees/remote_proto_channel.h"
+#include "cc/trees/surface_sequence_generator.h"
+#include "cc/trees/swap_promise_manager.h"
#include "content/common/content_switches_internal.h"
#include "content/common/gpu/client/context_provider_command_buffer.h"
#include "content/common/layer_tree_settings_factory.h"
@@ -627,13 +629,14 @@ std::unique_ptr<cc::SwapPromiseMonitor>
RenderWidgetCompositor::CreateLatencyInfoSwapPromiseMonitor(
ui::LatencyInfo* latency) {
return std::unique_ptr<cc::SwapPromiseMonitor>(
vmpstr 2016/09/12 20:44:31 does base::MakeUnique<cc::LatencyInfoSwapPromiseMo
Khushal 2016/09/12 22:53:03 Done.
- new cc::LatencyInfoSwapPromiseMonitor(latency, layer_tree_host_.get(),
- NULL));
+ new cc::LatencyInfoSwapPromiseMonitor(
+ latency, layer_tree_host_->GetSwapPromiseManager(), NULL));
}
void RenderWidgetCompositor::QueueSwapPromise(
std::unique_ptr<cc::SwapPromise> swap_promise) {
- layer_tree_host_->QueueSwapPromise(std::move(swap_promise));
+ layer_tree_host_->GetSwapPromiseManager()->QueueSwapPromise(
piman 2016/09/12 20:35:44 I have a mild preference to keeping a QueueSwapPro
Khushal 2016/09/12 22:53:03 Done. Retained those 2 APIs.
+ std::move(swap_promise));
}
int RenderWidgetCompositor::GetSourceFrameNumber() const {
@@ -932,7 +935,7 @@ void RenderWidgetCompositor::compositeAndReadbackAsync(
callback, base::Passed(&result)));
},
callback, base::Passed(&main_thread_task_runner)));
- layer_tree_host_->QueueSwapPromise(
+ layer_tree_host_->GetSwapPromiseManager()->QueueSwapPromise(
delegate_->RequestCopyOfOutputForLayoutTest(std::move(request)));
// Force a commit to happen. The temporary copy output request will
@@ -1126,7 +1129,8 @@ void RenderWidgetCompositor::SendCompositorProto(
}
void RenderWidgetCompositor::SetSurfaceClientId(uint32_t surface_client_id) {
- layer_tree_host_->SetSurfaceClientId(surface_client_id);
+ layer_tree_host_->GetSurfaceSequenceGenerator()->set_surface_client_id(
+ surface_client_id);
}
void RenderWidgetCompositor::OnHandleCompositorProto(

Powered by Google App Engine
This is Rietveld 408576698