Connect mojom::DisplayController from ash to ui.

services/ui/service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/ui/service.h"
 
 #include <set>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 194 matching lines @@
   registry->AddInterface<mojom::WindowManagerWindowTreeFactory>(this);
   registry->AddInterface<mojom::WindowTreeFactory>(this);
   if (test_config_)
     registry->AddInterface<WindowServerTest>(this);
 
   // On non-Linux platforms there will be no DeviceDataManager instance and no
   // purpose in adding the Mojo interface to connect to.
   if (input_device_server_.IsRegisteredAsObserver())
     input_device_server_.AddInterface(registry);
 
+  platform_screen_->AddInterfaces(registry);

[dcheng, 2016/09/12 18:04:30]

Dumb question: how do we guarantee that platform_screen_ outlives the lifetime
of ServiceRegistry? InterfaceFactorys don't appear to have any lifetime
guarantees.

[kylechar, 2016/09/12 18:28:15]

In this case platform_screen_ gets destroyed when the ui::Service that owns it
gets destroyed.

I'm not totally sure how Mojo application shutdown works but it looks like
shell:ServiceRunner is what ensures the order is correct. The
shell::InterfaceRegistry is local to the Run() method (owned by
shell::ServiceContext) while the shell:Service gets destroyed in the
shell::ServiceRunner destructor, so shell::InterfaceRegistry will always be
destroyed first.

[dcheng, 2016/09/13 01:04:48]

This would be nice to have documented somewhere.
(Unrelated, but I'm not sure why we need both the InterfaceFactory and Callback
methods of registering interfaces: seems like it'd be better if we only had
one?)

[kylechar, 2016/09/13 14:09:53]

T'll add comments on platform_screen_ and input_device_server_ noting they need
to outlive shell::InterfaceRegistry so someone doesn't call .reset() early. With
regards to your second question, I'm not sure, but I'm sure someone on the Mojo
team would at chromium-mojo?

https://groups.google.com/a/chromium.org/forum/#!forum/chromium-mojo

+
 #if defined(USE_OZONE)
   ui::OzonePlatform::GetInstance()->AddInterfaces(registry);
 #endif
 
   return true;
 }
 
 void Service::OnFirstDisplayReady() {
   PendingRequests requests;
   requests.swap(pending_requests_);
@@ skipping 124 matching lines @@
 
 void Service::Create(const shell::Identity& remote_identity,
                      mojom::WindowServerTestRequest request) {
   if (!test_config_)
     return;
   new ws::WindowServerTestImpl(window_server_.get(), std::move(request));
 }
 
 
 }  // namespace ui