made point lights linear attenuation; also fixed point light depth bug

made point lights linear attenuation; also fixed point light depth bug

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2323383002

Committed: https://skia.googlesource.com/skia/+/95315f0d6f77aef3700f604346f4e2558390e6f8

[vjiaoblack, 2016-09-09 17:22:55]

Description was changed from

==========
made point lights linear attenuation; also fixed point light depth bug

BUG=skia:
==========

to

==========
made point lights linear attenuation; also fixed point light depth bug

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2323383002
==========

[vjiaoblack, 2016-09-09 17:23:30]

vjiaoblack@google.com changed reviewers:
+ jvanverth@google.com

[vjiaoblack, 2016-09-09 17:23:31]

I know this is really 2 tiny CL's, but they were so tiny!

Could you review and let me know if it looks good?

[jvanverth1, 2016-09-09 18:18:33]

https://codereview.chromium.org/2323383002/diff/1/src/core/SkRadialShadowMapS...
File src/core/SkRadialShadowMapShader.cpp (right):

https://codereview.chromium.org/2323383002/diff/1/src/core/SkRadialShadowMapS...
src/core/SkRadialShadowMapShader.cpp:145: fragBuilder->codeAppend("float
closestDistHere = 2;");
Why 2?

https://codereview.chromium.org/2323383002/diff/1/src/core/SkShadowShader.cpp
File src/core/SkShadowShader.cpp (right):

https://codereview.chromium.org/2323383002/diff/1/src/core/SkShadowShader.cpp...
src/core/SkShadowShader.cpp:385: fragBuilder->codeAppendf("if (%s.b != 0 ||
depth == 2) {"
Again, why 2?

[vjiaoblack, 2016-09-09 18:24:36]

Basically, it's the depth of the shadow map, i think in the units of the max of
width and height.

Using 2 makes sure that if we have a light on screen, we wont get weird shadow
cutoffs!

https://codereview.chromium.org/2323383002/diff/1/src/core/SkRadialShadowMapS...
File src/core/SkRadialShadowMapShader.cpp (right):

https://codereview.chromium.org/2323383002/diff/1/src/core/SkRadialShadowMapS...
src/core/SkRadialShadowMapShader.cpp:145: fragBuilder->codeAppend("float
closestDistHere = 2;");
On 2016/09/09 18:18:33, jvanverth1 wrote:
> Why 2?

Done.

https://codereview.chromium.org/2323383002/diff/1/src/core/SkShadowShader.cpp
File src/core/SkShadowShader.cpp (right):

https://codereview.chromium.org/2323383002/diff/1/src/core/SkShadowShader.cpp...
src/core/SkShadowShader.cpp:385: fragBuilder->codeAppendf("if (%s.b != 0 ||
depth == 2) {"
On 2016/09/09 18:18:33, jvanverth1 wrote:
> Again, why 2?

Done.

[jvanverth1, 2016-09-09 18:28:26]

lgtm

[vjiaoblack, 2016-09-09 18:28:43]

The CQ bit was checked by vjiaoblack@google.com

[commit-bot: I haz the power, 2016-09-09 18:28:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 18:58:21]

Description was changed from

==========
made point lights linear attenuation; also fixed point light depth bug

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2323383002
==========

to

==========
made point lights linear attenuation; also fixed point light depth bug

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2323383002

Committed:
https://skia.googlesource.com/skia/+/95315f0d6f77aef3700f604346f4e2558390e6f8
==========

[commit-bot: I haz the power, 2016-09-09 18:58:21]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/95315f0d6f77aef3700f604346f4e2558390e6f8