Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: pkg/compiler/lib/src/kernel/accessors.dart

Issue 2323373003: fix other files in kernel after roll (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/kernel/unresolved.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/kernel/accessors.dart
diff --git a/pkg/compiler/lib/src/kernel/accessors.dart b/pkg/compiler/lib/src/kernel/accessors.dart
index 517bddd6acd22ee1bdf5c77f1a95aa999919e16c..afe66874c6969a06734cd013b42277c9fb49ccdd 100644
--- a/pkg/compiler/lib/src/kernel/accessors.dart
+++ b/pkg/compiler/lib/src/kernel/accessors.dart
@@ -77,24 +77,20 @@ class ClassStaticAccessor extends ir_accessors.StaticAccessor {
class SuperPropertyAccessor extends ir_accessors.SuperPropertyAccessor {
final UnresolvedVisitor builder;
- /// Name of the property attempted to be accessed, used to generate an
- /// error if unresolved.
- final String name;
-
SuperPropertyAccessor(
- this.builder, this.name, ir.Member readTarget, ir.Member writeTarget)
- : super(readTarget, writeTarget);
+ this.builder, ir.Name name, ir.Member getter, ir.Member setter)
+ : super(name, getter, setter);
@override
makeInvalidRead() {
// TODO(asgerf): Technically, we should invoke 'super.noSuchMethod' for
// this and the other invalid super cases.
- return builder.buildThrowUnresolvedSuperGetter(name);
+ return builder.buildThrowUnresolvedSuperGetter(name.name);
}
@override
makeInvalidWrite(ir.Expression value) {
- return builder.buildThrowUnresolvedSuperSetter(name, value);
+ return builder.buildThrowUnresolvedSuperSetter(name.name, value);
}
}
@@ -103,9 +99,9 @@ class SuperIndexAccessor extends ir_accessors.SuperIndexAccessor {
Kernel get kernel => builder.kernel;
- SuperIndexAccessor(this.builder, ir.Expression index, ir.Member readTarget,
- ir.Member writeTarget)
- : super(index, readTarget, writeTarget);
+ SuperIndexAccessor(
+ this.builder, ir.Expression index, ir.Member getter, ir.Member setter)
+ : super(index, getter, setter);
@override
makeInvalidRead() {
« no previous file with comments | « no previous file | pkg/compiler/lib/src/kernel/unresolved.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698