Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2323353002: GN: port a few missing Android bits from GYP. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: port a few missing Android bits from GYP. The SK_GAMMA_ defines change text rendering on Android. This is how they're set in GYP for Android... everyone else is default (sRGB). Linking AndroidSkDebugToStdOut.o causes SkDebugf to go to both logcat and stdout on Android. Without it, it only goes to logcat. The file has no effect on non-Android platforms. BUG=skia: Committed: https://skia.googlesource.com/skia/+/b37c034ac8ad590c70ceac9811ba42a0bf34642c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M BUILD.gn View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mtklein_C
4 years, 3 months ago (2016-09-09 16:07:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323353002/1
4 years, 3 months ago (2016-09-09 16:08:03 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-09 16:08:05 UTC) #7
jcgregorio
lgtm
4 years, 3 months ago (2016-09-09 18:06:15 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 18:07:48 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b37c034ac8ad590c70ceac9811ba42a0bf34642c

Powered by Google App Engine
This is Rietveld 408576698