Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Issue 2323343002: Update bookmark suggestions in open NTPs when removing their visit dates (Closed)

Created:
4 years, 3 months ago by vitaliii
Modified:
4 years, 3 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update bookmark suggestions in open NTPs when removing their visit dates This CL updates bookmarks suggestions in open NewTab pages after bookmark visit dates removal in order to remove the dates from all open pages. BUG=645462 Committed: https://crrev.com/d8487aa5d947a2f0e06a2292b4516db86e8994f0 Cr-Commit-Position: refs/heads/master@{#417919}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
vitaliii
Hi Marc, could you have a look please?
4 years, 3 months ago (2016-09-12 08:07:46 UTC) #2
Marc Treib
lgtm
4 years, 3 months ago (2016-09-12 09:31:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323343002/1
4 years, 3 months ago (2016-09-12 09:40:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 11:15:49 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 11:17:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8487aa5d947a2f0e06a2292b4516db86e8994f0
Cr-Commit-Position: refs/heads/master@{#417919}

Powered by Google App Engine
This is Rietveld 408576698