Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: content/browser/compositor/gpu_process_transport_factory.cc

Issue 2323303003: Turn ~GpuProcessTransportFactory DCHECK into a CHECK (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/compositor/gpu_process_transport_factory.cc
diff --git a/content/browser/compositor/gpu_process_transport_factory.cc b/content/browser/compositor/gpu_process_transport_factory.cc
index 27c0c4ba3c0dcd21cf6b0da933aed75696362966..643824fec22648fe1d31573619fa07816cc7bb0d 100644
--- a/content/browser/compositor/gpu_process_transport_factory.cc
+++ b/content/browser/compositor/gpu_process_transport_factory.cc
@@ -187,7 +187,8 @@ GpuProcessTransportFactory::GpuProcessTransportFactory()
}
GpuProcessTransportFactory::~GpuProcessTransportFactory() {
- DCHECK(per_compositor_data_.empty());
+ // If this fails, then we are leaking compositors.
danakj 2016/09/09 22:40:57 Can you TODO at the bug to go back to DCHECK
+ CHECK(per_compositor_data_.empty());
// Make sure the lost context callback doesn't try to run during destruction.
callback_factory_.InvalidateWeakPtrs();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698