Turn ~GpuProcessTransportFactory DCHECK into a CHECK

Turn ~GpuProcessTransportFactory DCHECK into a CHECK

If this DCHECK fails it means that some ui::Compositor has not been
destroyed and unregistered itself.  This is potentially really bad
as ui::Compositor assumes that its context factory outlives it.

This is to try to track down why this could be happening by
making it a larger failure than it has been in the past.

BUG=645075
Committed: https://crrev.com/2dd865b0da80e59a150b505a07d2fda05aa62d56
Cr-Commit-Position: refs/heads/master@{#418003}

[enne (OOO), 2016-09-09 22:39:46]

enne@chromium.org changed reviewers:
+ danakj@chromium.org

[enne (OOO), 2016-09-09 22:39:54]

T_T

[enne (OOO), 2016-09-09 22:39:56]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 22:40:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-09-09 22:40:57]

https://codereview.chromium.org/2323303003/diff/1/content/browser/compositor/...
File content/browser/compositor/gpu_process_transport_factory.cc (right):

https://codereview.chromium.org/2323303003/diff/1/content/browser/compositor/...
content/browser/compositor/gpu_process_transport_factory.cc:190: // If this
fails, then we are leaking compositors.
Can you TODO at the bug to go back to DCHECK

[danakj, 2016-09-09 22:41:02]

LGTM

[danakj, 2016-09-09 22:41:27]

You might wanna manually throw this at blink bots idk if it will run layout
tests from analyze.

[enne (OOO), 2016-09-09 22:46:58]

The CQ bit was unchecked by enne@chromium.org

[enne (OOO), 2016-09-12 17:36:06]

On 2016/09/09 at 22:41:27, danakj wrote:
> You might wanna manually throw this at blink bots idk if it will run layout
tests from analyze.

Blink bots seem fine.  I'm inclined to just land this, unless you can think of
anything else to check first.

[danakj, 2016-09-12 18:38:13]

On Mon, Sep 12, 2016 at 10:36 AM, enne@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> On 2016/09/09 at 22:41:27, danakj wrote:
> > You might wanna manually throw this at blink bots idk if it will run
> layout
> tests from analyze.
>
> Blink bots seem fine. I'm inclined to just land this, unless you can think
> of
> anything else to check first.
>

Okie sounds good.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[enne (OOO), 2016-09-12 18:42:08]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2016-09-12 18:42:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 19:36:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-12 19:38:00]

Description was changed from

==========
Turn ~GpuProcessTransportFactory DCHECK into a CHECK

If this DCHECK fails it means that some ui::Compositor has not been
destroyed and unregistered itself.  This is potentially really bad
as ui::Compositor assumes that its context factory outlives it.

This is to try to track down why this could be happening by
making it a larger failure than it has been in the past.

BUG=645075
==========

to

==========
Turn ~GpuProcessTransportFactory DCHECK into a CHECK

If this DCHECK fails it means that some ui::Compositor has not been
destroyed and unregistered itself.  This is potentially really bad
as ui::Compositor assumes that its context factory outlives it.

This is to try to track down why this could be happening by
making it a larger failure than it has been in the past.

BUG=645075

Committed: https://crrev.com/2dd865b0da80e59a150b505a07d2fda05aa62d56
Cr-Commit-Position: refs/heads/master@{#418003}
==========

[commit-bot: I haz the power, 2016-09-12 19:38:01]

Patchset 1 (id:??) landed as
https://crrev.com/2dd865b0da80e59a150b505a07d2fda05aa62d56
Cr-Commit-Position: refs/heads/master@{#418003}

[enne (OOO), 2016-09-14 18:51:34]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2340083002/ by enne@chromium.org.

The reason for reverting is: Found a local repro for where this is happening..