Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 23233003: Revert 218286 "Set chrome_multiple_dll=1 by default on Windows i..." (Closed)

Created:
7 years, 4 months ago by scottmg
Modified:
7 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 218286 "Set chrome_multiple_dll=1 by default on Windows i..." chrome_frame_net_tests and nacl_integration x86-32 broke. > Set chrome_multiple_dll=1 by default on Windows in static_library > > TBR=jam@chromium.org > R=jamesr@chromium.org > BUG=237249 > > Review URL: https://chromiumcodereview.appspot.com/22909017 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M trunk/src/build/common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/chrome_android.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/content.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scottmg
7 years, 4 months ago (2013-08-19 17:08:10 UTC) #1
scottmg
7 years, 4 months ago (2013-08-19 17:08:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r218289.

Powered by Google App Engine
This is Rietveld 408576698