Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2323293002: Revert of [heap] Fix a formatting bug in --trace-incremental-marking. (Closed)

Created:
4 years, 3 months ago by ulan
Modified:
4 years, 3 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Fix a formatting bug in --trace-incremental-marking. (patchset #2 id:20001 of https://codereview.chromium.org/2324623004/ ) Reason for revert: Revert to check if this is causing perf regressions in crbug.com/645411 Original issue's description: > [heap] Fix a formatting bug in --trace-incremental-marking. > > BUG= > > Committed: https://crrev.com/212624b7570cd1c1cfad7cf958203b05af961637 > Cr-Commit-Position: refs/heads/master@{#39278} TBR=mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/6c2a217ef771b1d770cc223b9c4908715fe573d1 Cr-Commit-Position: refs/heads/master@{#39305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M src/heap/heap.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/isolate.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
ulan
Created Revert of [heap] Fix a formatting bug in --trace-incremental-marking.
4 years, 3 months ago (2016-09-09 11:35:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323293002/1
4 years, 3 months ago (2016-09-09 11:35:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 11:35:31 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 11:36:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c2a217ef771b1d770cc223b9c4908715fe573d1
Cr-Commit-Position: refs/heads/master@{#39305}

Powered by Google App Engine
This is Rietveld 408576698