Revert of clang plugin: Compute absolute paths on Windows as well.

Revert of clang plugin: Compute absolute paths on Windows as well. (patchset #6 id:100001 of https://codereview.chromium.org/2318733002/ )

Reason for revert:
The bots are sad. From https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux%20%28dbg%29/builds/4060/steps/gclient%20runhooks/logs/stdio

/b/c/b/ClangToTLinux__dbg_/src/tools/clang/plugins/ChromeClassTester.cpp: In member function ‘bool ChromeClassTester::InBannedDirectory(clang::SourceLocation)’:
/b/c/b/ClangToTLinux__dbg_/src/tools/clang/plugins/ChromeClassTester.cpp:129:41: error: ‘resolvedPath’ was not declared in this scope
   } else if (realpath(filename.c_str(), resolvedPath)) {
                                         ^
/b/c/b/ClangToTLinux__dbg_/src/tools/clang/plugins/ChromeClassTester.cpp:130:33: error: redeclaration of ‘char resolvedPath [4096]’
     char resolvedPath[MAXPATHLEN];
                                 ^
/b/c/b/ClangToTLinux__dbg_/src/tools/clang/plugins/ChromeClassTester.cpp:129:41: error: ‘<typeprefixerror>resolvedPath’ previously declared here
   } else if (realpath(filename.c_str(), resolvedPath)) {
                                         ^

Original issue's description:
> clang plugin: Compute absolute paths on Windows as well.
>
> The motivation is to suppress diagnostics on the v8 bot,
> which have "v8" somewhere on the path, but not in the
> filename segments the compiler sees.  This makes the
> behavior on Windows match the behavior on non-Windows.
>
> BUG=644096
> NOTRY=true
>
> Committed: https://crrev.com/df0eb747fca2699d116ad80d0ccbd967317fdbd4
> Cr-Commit-Position: refs/heads/master@{#417701}

TBR=dcheng@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=644096
Committed: https://crrev.com/4b850c5bf7d78377cc2e0b00097f9d9947bbdfb5
Cr-Commit-Position: refs/heads/master@{#417762}

[hans, 2016-09-09 23:27:13]

The CQ bit was checked by hans@chromium.org

[hans, 2016-09-09 23:27:14]

Created Revert of clang plugin: Compute absolute paths on Windows as well.

[commit-bot: I haz the power, 2016-09-09 23:27:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 23:28:33]

Description was changed from

==========
Revert of clang plugin: Compute absolute paths on Windows as well. (patchset #6
id:100001 of https://codereview.chromium.org/2318733002/ )

Reason for revert:
The bots are sad. From
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux%20%28dbg%29/...


/b/c/b/ClangToTLinux__dbg_/src/tools/clang/plugins/ChromeClassTester.cpp: In
member function ‘bool
ChromeClassTester::InBannedDirectory(clang::SourceLocation)’:
/b/c/b/ClangToTLinux__dbg_/src/tools/clang/plugins/ChromeClassTester.cpp:129:41:
error: ‘resolvedPath’ was not declared in this scope
   } else if (realpath(filename.c_str(), resolvedPath)) {
                                         ^
/b/c/b/ClangToTLinux__dbg_/src/tools/clang/plugins/ChromeClassTester.cpp:130:33:
error: redeclaration of ‘char resolvedPath [4096]’
     char resolvedPath[MAXPATHLEN];
                                 ^
/b/c/b/ClangToTLinux__dbg_/src/tools/clang/plugins/ChromeClassTester.cpp:129:41:
error: ‘<typeprefixerror>resolvedPath’ previously declared here
   } else if (realpath(filename.c_str(), resolvedPath)) {
                                         ^

Original issue's description:
> clang plugin: Compute absolute paths on Windows as well.
> 
> The motivation is to suppress diagnostics on the v8 bot,
> which have "v8" somewhere on the path, but not in the
> filename segments the compiler sees.  This makes the
> behavior on Windows match the behavior on non-Windows.
> 
> BUG=644096
> NOTRY=true
> 
> Committed: https://crrev.com/df0eb747fca2699d116ad80d0ccbd967317fdbd4
> Cr-Commit-Position: refs/heads/master@{#417701}

TBR=dcheng@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=644096
==========

to

==========
Revert of clang plugin: Compute absolute paths on Windows as well. (patchset #6
id:100001 of https://codereview.chromium.org/2318733002/ )

Reason for revert:
The bots are sad. From
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux%20%28dbg%29/...


/b/c/b/ClangToTLinux__dbg_/src/tools/clang/plugins/ChromeClassTester.cpp: In
member function ‘bool
ChromeClassTester::InBannedDirectory(clang::SourceLocation)’:
/b/c/b/ClangToTLinux__dbg_/src/tools/clang/plugins/ChromeClassTester.cpp:129:41:
error: ‘resolvedPath’ was not declared in this scope
   } else if (realpath(filename.c_str(), resolvedPath)) {
                                         ^
/b/c/b/ClangToTLinux__dbg_/src/tools/clang/plugins/ChromeClassTester.cpp:130:33:
error: redeclaration of ‘char resolvedPath [4096]’
     char resolvedPath[MAXPATHLEN];
                                 ^
/b/c/b/ClangToTLinux__dbg_/src/tools/clang/plugins/ChromeClassTester.cpp:129:41:
error: ‘<typeprefixerror>resolvedPath’ previously declared here
   } else if (realpath(filename.c_str(), resolvedPath)) {
                                         ^

Original issue's description:
> clang plugin: Compute absolute paths on Windows as well.
> 
> The motivation is to suppress diagnostics on the v8 bot,
> which have "v8" somewhere on the path, but not in the
> filename segments the compiler sees.  This makes the
> behavior on Windows match the behavior on non-Windows.
> 
> BUG=644096
> NOTRY=true
> 
> Committed: https://crrev.com/df0eb747fca2699d116ad80d0ccbd967317fdbd4
> Cr-Commit-Position: refs/heads/master@{#417701}

TBR=dcheng@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=644096
==========

[commit-bot: I haz the power, 2016-09-09 23:28:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-09 23:30:56]

Description was changed from

==========
Revert of clang plugin: Compute absolute paths on Windows as well. (patchset #6
id:100001 of https://codereview.chromium.org/2318733002/ )

Reason for revert:
The bots are sad. From
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux%20%28dbg%29/...


/b/c/b/ClangToTLinux__dbg_/src/tools/clang/plugins/ChromeClassTester.cpp: In
member function ‘bool
ChromeClassTester::InBannedDirectory(clang::SourceLocation)’:
/b/c/b/ClangToTLinux__dbg_/src/tools/clang/plugins/ChromeClassTester.cpp:129:41:
error: ‘resolvedPath’ was not declared in this scope
   } else if (realpath(filename.c_str(), resolvedPath)) {
                                         ^
/b/c/b/ClangToTLinux__dbg_/src/tools/clang/plugins/ChromeClassTester.cpp:130:33:
error: redeclaration of ‘char resolvedPath [4096]’
     char resolvedPath[MAXPATHLEN];
                                 ^
/b/c/b/ClangToTLinux__dbg_/src/tools/clang/plugins/ChromeClassTester.cpp:129:41:
error: ‘<typeprefixerror>resolvedPath’ previously declared here
   } else if (realpath(filename.c_str(), resolvedPath)) {
                                         ^

Original issue's description:
> clang plugin: Compute absolute paths on Windows as well.
> 
> The motivation is to suppress diagnostics on the v8 bot,
> which have "v8" somewhere on the path, but not in the
> filename segments the compiler sees.  This makes the
> behavior on Windows match the behavior on non-Windows.
> 
> BUG=644096
> NOTRY=true
> 
> Committed: https://crrev.com/df0eb747fca2699d116ad80d0ccbd967317fdbd4
> Cr-Commit-Position: refs/heads/master@{#417701}

TBR=dcheng@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=644096
==========

to

==========
Revert of clang plugin: Compute absolute paths on Windows as well. (patchset #6
id:100001 of https://codereview.chromium.org/2318733002/ )

Reason for revert:
The bots are sad. From
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux%20%28dbg%29/...

/b/c/b/ClangToTLinux__dbg_/src/tools/clang/plugins/ChromeClassTester.cpp: In
member function ‘bool
ChromeClassTester::InBannedDirectory(clang::SourceLocation)’:
/b/c/b/ClangToTLinux__dbg_/src/tools/clang/plugins/ChromeClassTester.cpp:129:41:
error: ‘resolvedPath’ was not declared in this scope
   } else if (realpath(filename.c_str(), resolvedPath)) {
                                         ^
/b/c/b/ClangToTLinux__dbg_/src/tools/clang/plugins/ChromeClassTester.cpp:130:33:
error: redeclaration of ‘char resolvedPath [4096]’
     char resolvedPath[MAXPATHLEN];
                                 ^
/b/c/b/ClangToTLinux__dbg_/src/tools/clang/plugins/ChromeClassTester.cpp:129:41:
error: ‘<typeprefixerror>resolvedPath’ previously declared here
   } else if (realpath(filename.c_str(), resolvedPath)) {
                                         ^

Original issue's description:
> clang plugin: Compute absolute paths on Windows as well.
>
> The motivation is to suppress diagnostics on the v8 bot,
> which have "v8" somewhere on the path, but not in the
> filename segments the compiler sees.  This makes the
> behavior on Windows match the behavior on non-Windows.
>
> BUG=644096
> NOTRY=true
>
> Committed: https://crrev.com/df0eb747fca2699d116ad80d0ccbd967317fdbd4
> Cr-Commit-Position: refs/heads/master@{#417701}

TBR=dcheng@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=644096

Committed: https://crrev.com/4b850c5bf7d78377cc2e0b00097f9d9947bbdfb5
Cr-Commit-Position: refs/heads/master@{#417762}
==========

[commit-bot: I haz the power, 2016-09-09 23:30:57]

Patchset 1 (id:??) landed as
https://crrev.com/4b850c5bf7d78377cc2e0b00097f9d9947bbdfb5
Cr-Commit-Position: refs/heads/master@{#417762}

[Nico, 2016-09-09 23:31:29]

Bleh, I carefully tested this -- on Windows. Should've omitted the unrelated
change on non-Windows (which was wrong). Thanks for the revert, will reland
soon.