Ignore Javascript urls dropped on tabs

chrome/browser/ui/views/tabs/tab_strip.cc

Index: chrome/browser/ui/views/tabs/tab_strip.cc
diff --git a/chrome/browser/ui/views/tabs/tab_strip.cc b/chrome/browser/ui/views/tabs/tab_strip.cc
index 7800dc987e5ae98dd56dfdc7a7189dc17e99408a..32fed77ae6278fe117926f102c259e4b3999d06d 100644
--- a/chrome/browser/ui/views/tabs/tab_strip.cc
+++ b/chrome/browser/ui/views/tabs/tab_strip.cc
@@ -1629,6 +1629,9 @@ int TabStrip::OnDragUpdated(const DropTargetEvent& event) {
   if (!drop_info_->file_supported)
     return ui::DragDropTypes::DRAG_NONE;
 
+  if ((drop_info_->url).SchemeIs(url::kJavaScriptScheme))

[Peter Kasting, 2016/09/09 20:43:06]

Nit: Remove unnecessary first set of parens.  Combine with conditional above.

[elawrence, 2016/09/12 21:42:58]

Done.

+    return ui::DragDropTypes::DRAG_NONE;
+
   return GetDropEffect(event);
 }
 
@@ -1654,7 +1657,8 @@ int TabStrip::OnPerformDrop(const DropTargetEvent& event) {
   if (!file_supported ||
       !event.data().GetURLAndTitle(
            ui::OSExchangeData::CONVERT_FILENAMES, &url, &title) ||
-      !url.is_valid())
+      !url.is_valid() ||
+      url.SchemeIs(url::kJavaScriptScheme))
     return ui::DragDropTypes::DRAG_NONE;
 
   controller_->PerformDrop(drop_before, drop_index, url);