Issue 2323273002: [inspector] Drop V8_VERSION checks.

Issue 2323273002: [inspector] Drop V8_VERSION checks. (Closed)

Created:
4 years, 3 months ago by alph

Modified:
4 years, 3 months ago

Reviewers:
dgozman

CC:
v8-reviews_googlegroups.com

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[inspector] Drop V8_VERSION checks. BUG=chromium:635948 Committed: https://crrev.com/bb0b8b2da391355446376699000384bfcd86e804 Cr-Commit-Position: refs/heads/master@{#39314}

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -43 lines)			Patch
M	src/inspector/V8HeapProfilerAgentImpl.cpp	View	8 chunks	+0 lines, -17 lines	0 comments	Download
M	src/inspector/V8ProfilerAgentImpl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/inspector/V8ProfilerAgentImpl.cpp	View	8 chunks	+4 lines, -23 lines	0 comments	Download
M	src/inspector/V8StackTraceImpl.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 14 (9 generated)

dgozman

lgtm Please attribute all migration-related patches to BUG=chromium:635948

4 years, 3 months ago (2016-09-09 14:48:38 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323273002/1

4 years, 3 months ago (2016-09-09 15:50:27 UTC) #10

commit-bot: I haz the power

4 years, 3 months ago (2016-09-09 15:52:41 UTC) #14

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/bb0b8b2da391355446376699000384bfcd86e804
Cr-Commit-Position: refs/heads/master@{#39314}