Issue 232323002: Revert of remove sprintf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 232323002: Revert of remove sprintf (Closed)

Created:
6 years, 8 months ago by mtklein

Modified:
6 years, 8 months ago

Reviewers:
hal.canary

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Revert of remove sprintf (https://codereview.chromium.org/230413005/) Reason for revert: Boo, hiss, SK_ARRAY_COUNT not defined in skia_launcher.cpp! Original issue's description: > remove sprintf > > Committed: http://code.google.com/p/skia/source/detail?r=14123 TBR=halcanary@google.com NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14125

Created: 6 years, 8 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -11 lines)			Patch
	M	platform_tools/android/launcher/skia_launcher.cpp	View		2 chunks	+1 line, -6 lines	0 comments	Download
	M	src/core/SkError.cpp	View		2 chunks	+1 line, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/232323002/1

6 years, 8 months ago (2014-04-09 23:38:52 UTC) #2

Message was sent while issue was closed.

Change committed as 14125