Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2323213002: Reduce the amount of text to perf test for long-line-nowrap-collapse (Closed)

Created:
4 years, 3 months ago by kojii
Modified:
4 years, 3 months ago
Reviewers:
drott, eae
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce the amount of text to perf test for long-line-nowrap-collapse When a perf improvements for collapsing whitespace[1] landed, following tests were adjusted to be 12x slower, to match to the test without whitespace collapsing. However, these tests then timeout on reference build. This patch defers the adjust until the reference build is updated. PerformanceTests/Layout/long-line-nowrap-collapse.html PerformanceTests/Layout/long-line-nowrap-spans-collapse.html [1] https://codereview.chromium.org/2285053002 BUG=642884 Committed: https://crrev.com/f91d8dafdbc7951f3ac8ce4d89c2535b9eeb5249 Cr-Commit-Position: refs/heads/master@{#417557}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/PerformanceTests/Layout/long-line-nowrap-collapse.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/long-line-nowrap-spans-collapse.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (13 generated)
kojii
PTAL.
4 years, 3 months ago (2016-09-09 04:22:40 UTC) #10
drott
LGTM, how is the reference build updated? Is it just a build that's older by ...
4 years, 3 months ago (2016-09-09 08:35:18 UTC) #13
eae
LGTM
4 years, 3 months ago (2016-09-09 08:38:06 UTC) #14
kojii
On 2016/09/09 at 08:35:18, drott wrote: > how is the reference build updated? Is it ...
4 years, 3 months ago (2016-09-09 11:26:02 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323213002/1
4 years, 3 months ago (2016-09-09 11:26:23 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 11:30:06 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 11:31:44 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f91d8dafdbc7951f3ac8ce4d89c2535b9eeb5249
Cr-Commit-Position: refs/heads/master@{#417557}

Powered by Google App Engine
This is Rietveld 408576698