|
|
DescriptionReduce the amount of text to perf test for long-line-nowrap-collapse
When a perf improvements for collapsing whitespace[1] landed,
following tests were adjusted to be 12x slower, to match to the test
without whitespace collapsing.
However, these tests then timeout on reference build.
This patch defers the adjust until the reference build is updated.
PerformanceTests/Layout/long-line-nowrap-collapse.html
PerformanceTests/Layout/long-line-nowrap-spans-collapse.html
[1] https://codereview.chromium.org/2285053002
BUG=642884
Committed: https://crrev.com/f91d8dafdbc7951f3ac8ce4d89c2535b9eeb5249
Cr-Commit-Position: refs/heads/master@{#417557}
Patch Set 1 #
Messages
Total messages: 20 (13 generated)
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== perf BUG=642884 ========== to ========== Reduce the amount of text to perf test for long-line-nowrap-collapse When a perf improvements for collapsing whitespace[1] landed, following tests were adjusted to 12x slower to match to the test without whitespace collapsing. However, these tests then timeout on reference build. This patch defers the adjust until the refererence build is updated. PerformanceTests/Layout/long-line-nowrap-collapse.html PerformanceTests/Layout/long-line-nowrap-spans-collapse.html [1] https://codereview.chromium.org/2285053002 BUG=642884 ==========
Description was changed from ========== Reduce the amount of text to perf test for long-line-nowrap-collapse When a perf improvements for collapsing whitespace[1] landed, following tests were adjusted to 12x slower to match to the test without whitespace collapsing. However, these tests then timeout on reference build. This patch defers the adjust until the refererence build is updated. PerformanceTests/Layout/long-line-nowrap-collapse.html PerformanceTests/Layout/long-line-nowrap-spans-collapse.html [1] https://codereview.chromium.org/2285053002 BUG=642884 ========== to ========== Reduce the amount of text to perf test for long-line-nowrap-collapse When a perf improvements for collapsing whitespace[1] landed, following tests were adjusted to be 12x slower, to match to the test without whitespace collapsing. However, these tests then timeout on reference build. This patch defers the adjust until the refererence build is updated. PerformanceTests/Layout/long-line-nowrap-collapse.html PerformanceTests/Layout/long-line-nowrap-spans-collapse.html [1] https://codereview.chromium.org/2285053002 BUG=642884 ==========
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Description was changed from ========== Reduce the amount of text to perf test for long-line-nowrap-collapse When a perf improvements for collapsing whitespace[1] landed, following tests were adjusted to be 12x slower, to match to the test without whitespace collapsing. However, these tests then timeout on reference build. This patch defers the adjust until the refererence build is updated. PerformanceTests/Layout/long-line-nowrap-collapse.html PerformanceTests/Layout/long-line-nowrap-spans-collapse.html [1] https://codereview.chromium.org/2285053002 BUG=642884 ========== to ========== Reduce the amount of text to perf test for long-line-nowrap-collapse When a perf improvements for collapsing whitespace[1] landed, following tests were adjusted to be 12x slower, to match to the test without whitespace collapsing. However, these tests then timeout on reference build. This patch reverts the adjust until the refererence build is updated. PerformanceTests/Layout/long-line-nowrap-collapse.html PerformanceTests/Layout/long-line-nowrap-spans-collapse.html [1] https://codereview.chromium.org/2285053002 BUG=642884 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Reduce the amount of text to perf test for long-line-nowrap-collapse When a perf improvements for collapsing whitespace[1] landed, following tests were adjusted to be 12x slower, to match to the test without whitespace collapsing. However, these tests then timeout on reference build. This patch defers the adjust until the refererence build is updated. PerformanceTests/Layout/long-line-nowrap-collapse.html PerformanceTests/Layout/long-line-nowrap-spans-collapse.html [1] https://codereview.chromium.org/2285053002 BUG=642884 ========== to ========== Reduce the amount of text to perf test for long-line-nowrap-collapse When a perf improvements for collapsing whitespace[1] landed, following tests were adjusted to be 12x slower, to match to the test without whitespace collapsing. However, these tests then timeout on reference build. This patch defers the adjust until the reference build is updated. PerformanceTests/Layout/long-line-nowrap-collapse.html PerformanceTests/Layout/long-line-nowrap-spans-collapse.html [1] https://codereview.chromium.org/2285053002 BUG=642884 ==========
kojii@chromium.org changed reviewers: + drott@chromium.org, eae@chromium.org
PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM, how is the reference build updated? Is it just a build that's older by a given amount of time?
LGTM
On 2016/09/09 at 08:35:18, drott wrote: > how is the reference build updated? Is it just a build that's older by a given amount of time? In the bug, someone said it's a "last known stable build of chrome" but how is updated isn't clear after two days I asked there, we can probably know by watching the graph since the change is so obvious; 20x for win, 40x for Android.
The CQ bit was checked by kojii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Reduce the amount of text to perf test for long-line-nowrap-collapse When a perf improvements for collapsing whitespace[1] landed, following tests were adjusted to be 12x slower, to match to the test without whitespace collapsing. However, these tests then timeout on reference build. This patch defers the adjust until the reference build is updated. PerformanceTests/Layout/long-line-nowrap-collapse.html PerformanceTests/Layout/long-line-nowrap-spans-collapse.html [1] https://codereview.chromium.org/2285053002 BUG=642884 ========== to ========== Reduce the amount of text to perf test for long-line-nowrap-collapse When a perf improvements for collapsing whitespace[1] landed, following tests were adjusted to be 12x slower, to match to the test without whitespace collapsing. However, these tests then timeout on reference build. This patch defers the adjust until the reference build is updated. PerformanceTests/Layout/long-line-nowrap-collapse.html PerformanceTests/Layout/long-line-nowrap-spans-collapse.html [1] https://codereview.chromium.org/2285053002 BUG=642884 Committed: https://crrev.com/f91d8dafdbc7951f3ac8ce4d89c2535b9eeb5249 Cr-Commit-Position: refs/heads/master@{#417557} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f91d8dafdbc7951f3ac8ce4d89c2535b9eeb5249 Cr-Commit-Position: refs/heads/master@{#417557} |