Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 2323173004: [inspector] handle context destroyed after console.log (Closed)

Created:
4 years, 3 months ago by kozy
Modified:
4 years, 3 months ago
Reviewers:
dgozman, alph
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] handle context destroyed after console.log BUG=chromium:642496 R=dgozman@chromium.org Committed: https://crrev.com/71781f31a26cf9122d125f5f58d4a292875b7b0a Cr-Commit-Position: refs/heads/master@{#39322}

Patch Set 1 #

Patch Set 2 : fix formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -25 lines) Patch
M src/inspector/InjectedScript.cpp View 1 7 chunks +12 lines, -9 lines 0 comments Download
M src/inspector/V8ConsoleAgentImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/inspector/V8ConsoleAgentImpl.cpp View 1 1 chunk +6 lines, -3 lines 0 comments Download
M src/inspector/V8ConsoleMessage.cpp View 1 4 chunks +15 lines, -8 lines 0 comments Download
M src/inspector/V8InspectorImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/inspector/V8InspectorImpl.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M src/inspector/V8RuntimeAgentImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/inspector/V8RuntimeAgentImpl.cpp View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
kozy
Dmitry, please take a look, its V8 part of https://codereview.chromium.org/2318853002/. I will land tests separately.
4 years, 3 months ago (2016-09-09 23:31:42 UTC) #2
dgozman
lgtm
4 years, 3 months ago (2016-09-09 23:36:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323173004/1
4 years, 3 months ago (2016-09-09 23:36:57 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-09 23:36:58 UTC) #8
alph
RS lgtm
4 years, 3 months ago (2016-09-10 00:47:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323173004/1
4 years, 3 months ago (2016-09-10 00:50:23 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/23743)
4 years, 3 months ago (2016-09-10 00:53:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323173004/20001
4 years, 3 months ago (2016-09-10 01:10:03 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-10 01:48:28 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-10 01:49:12 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/71781f31a26cf9122d125f5f58d4a292875b7b0a
Cr-Commit-Position: refs/heads/master@{#39322}

Powered by Google App Engine
This is Rietveld 408576698