Speed up ARC boot if the user launches ARC app while ARC is not ready

Speed up ARC boot if the user launches ARC app while ARC is not ready

On some boards, ARC processes run in a restricted cgroups by default
so that booting ARC won't slow down Chrome's user session restoration.

However, such a cgroups restriction is not always relevant. This CL
is for removing the cgroups restriction when the user tries to launch
an ARC app before ARC system gets ready (so that ARC system finishes
booting quickly.)

Chromium OS (session_manager) side CL is:
https://chromium-review.googlesource.com/#/c/382878/

BUG=chrome-os-partner:56555
TEST=Manually checked that the D-Bus method in session_manager is
 called.

Committed: https://crrev.com/363005462f464bc319163b22c8eef8874a205868
Cr-Commit-Position: refs/heads/master@{#417768}

[Yusuke Sato, 2016-09-08 23:28:44]

yusukes@chromium.org changed reviewers:
+ hashimoto@chromium.org, khmel@chromium.org, skuhne@chromium.org,
xiyuan@chromium.org

[Yusuke Sato, 2016-09-08 23:28:45]

Yury, please have a look.

OWNERs PTAL too.

hashimoto@: chromeos/dbus/
skuhne@: chrome/browser/ui/ash/launcher/
xiyuan@: chrome/browser/ui/app_list/arc/

Thanks!

[Yusuke Sato, 2016-09-08 23:32:09]

(I'm going to run trybots once
https://chromium-review.googlesource.com/#/c/383074/ is landed and I uprev
third_party/cros_system_api/. Currently, try will fail because
third_party/cros_system_api/ doesn't define
login_manager::kSessionManagerPrioritizeArcInstance.)

[khmel, 2016-09-08 23:35:28]

https://codereview.chromium.org/2323133002/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc
(right):

https://codereview.chromium.org/2323133002/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc:222:
arc::PrioritizeArcInstance();
nit: Probably it is better to put this into arc_app_utils into LaunchApp. This
would make logic more clear. App app launches pass through arc_app_utils. In
this case you may leave this file untouched and remove declaration from
arc_app_utils.h

[Daniel Erat, 2016-09-08 23:35:53]

derat@chromium.org changed reviewers:
+ derat@chromium.org

[Daniel Erat, 2016-09-08 23:35:54]

lgtm for chromeos/dbus

[hashimoto, 2016-09-09 01:18:32]

chromeos/dbus/ lgtm

[Mr4D (OOO till 08-26), 2016-09-09 16:05:27]

c/b/u/a/l lgtm

[Yusuke Sato, 2016-09-09 16:20:13]

khmel, xiyuan, ptal at c/b/.

https://codereview.chromium.org/2323133002/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc
(right):

https://codereview.chromium.org/2323133002/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc:222:
arc::PrioritizeArcInstance();
On 2016/09/08 23:35:27, khmel wrote:
> nit: Probably it is better to put this into arc_app_utils into LaunchApp. This
> would make logic more clear. App app launches pass through arc_app_utils. In
> this case you may leave this file untouched and remove declaration from
> arc_app_utils.h

That's simpler, thanks. Done.

[khmel, 2016-09-09 16:21:09]

On 2016/09/09 16:20:13, Yusuke Sato wrote:
> khmel, xiyuan, ptal at c/b/.
> 
>
https://codereview.chromium.org/2323133002/diff/1/chrome/browser/ui/ash/launc...
> File chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc
> (right):
> 
>
https://codereview.chromium.org/2323133002/diff/1/chrome/browser/ui/ash/launc...
> chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc:222:
> arc::PrioritizeArcInstance();
> On 2016/09/08 23:35:27, khmel wrote:
> > nit: Probably it is better to put this into arc_app_utils into LaunchApp.
This
> > would make logic more clear. App app launches pass through arc_app_utils. In
> > this case you may leave this file untouched and remove declaration from
> > arc_app_utils.h
> 
> That's simpler, thanks. Done.

lgtm

[Yusuke Sato, 2016-09-09 18:27:33]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 18:28:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 18:43:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 18:43:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yusuke Sato, 2016-09-09 19:48:11]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 19:48:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2016-09-09 20:15:24]

lgtm

Sorry replying late.

[commit-bot: I haz the power, 2016-09-09 20:39:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 20:39:28]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2016-09-09 23:39:26]

The CQ bit was checked by yusukes@chromium.org

[Yusuke Sato, 2016-09-09 23:39:27]

The patchset sent to the CQ was uploaded after l-g-t-m from derat@chromium.org,
hashimoto@chromium.org, skuhne@chromium.org, khmel@chromium.org
Link to the patchset: https://codereview.chromium.org/2323133002/#ps60001
(title: "Fix unit_tests")

[commit-bot: I haz the power, 2016-09-09 23:39:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 23:44:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-09 23:46:56]

Description was changed from

==========
Speed up ARC boot if the user launches ARC app while ARC is not ready

On some boards, ARC processes run in a restricted cgroups by default
so that booting ARC won't slow down Chrome's user session restoration.

However, such a cgroups restriction is not always relevant. This CL
is for removing the cgroups restriction when the user tries to launch
an ARC app before ARC system gets ready (so that ARC system finishes
booting quickly.)

Chromium OS (session_manager) side CL is:
https://chromium-review.googlesource.com/#/c/382878/

BUG=chrome-os-partner:56555
TEST=Manually checked that the D-Bus method in session_manager is
 called.
==========

to

==========
Speed up ARC boot if the user launches ARC app while ARC is not ready

On some boards, ARC processes run in a restricted cgroups by default
so that booting ARC won't slow down Chrome's user session restoration.

However, such a cgroups restriction is not always relevant. This CL
is for removing the cgroups restriction when the user tries to launch
an ARC app before ARC system gets ready (so that ARC system finishes
booting quickly.)

Chromium OS (session_manager) side CL is:
https://chromium-review.googlesource.com/#/c/382878/

BUG=chrome-os-partner:56555
TEST=Manually checked that the D-Bus method in session_manager is
 called.

Committed: https://crrev.com/363005462f464bc319163b22c8eef8874a205868
Cr-Commit-Position: refs/heads/master@{#417768}
==========

[commit-bot: I haz the power, 2016-09-09 23:46:57]

Patchset 4 (id:??) landed as
https://crrev.com/363005462f464bc319163b22c8eef8874a205868
Cr-Commit-Position: refs/heads/master@{#417768}