Add StrictTypeChecking to CRC2D.{drawImage,createPattern}

Add StrictTypeChecking to CRC2D.{drawImage,createPattern}

This moves the null-check out into generated bindings code.
The non-standard method drawImageFromRect(...) keeps the null-check,
and has its first argument marked nullable because of that.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171477

[Justin Novosad, 2014-04-14 14:29:42]

https://codereview.chromium.org/232313004/diff/1/Source/core/html/canvas/Canv...
File Source/core/html/canvas/CanvasRenderingContext2D.idl (right):

https://codereview.chromium.org/232313004/diff/1/Source/core/html/canvas/Canv...
Source/core/html/canvas/CanvasRenderingContext2D.idl:145: [StrictTypeChecking]
void drawImageFromRect(HTMLImageElement? image,
This is API is not even in the spec. We should probably consider deprecating it
since is is non-orthogonal.  Anyways, why did you chose to make image nullable
in this case?

[fs, 2014-04-14 15:00:47]

https://codereview.chromium.org/232313004/diff/1/Source/core/html/canvas/Canv...
File Source/core/html/canvas/CanvasRenderingContext2D.idl (right):

https://codereview.chromium.org/232313004/diff/1/Source/core/html/canvas/Canv...
Source/core/html/canvas/CanvasRenderingContext2D.idl:145: [StrictTypeChecking]
void drawImageFromRect(HTMLImageElement? image,
On 2014/04/14 14:29:42, junov wrote:
> This is API is not even in the spec. We should probably consider deprecating
it
> since is is non-orthogonal.  Anyways, why did you chose to make image nullable
> in this case?

I made it nullable so that the behavior would be preserved. 'HTMLImageElement'
would previously accept null/undefined/HTMLImageElement, and that would be
equivalent to using a nullable type w/ [StrictTypeChecking]. The implementation
just calls drawImageInternal with IGNORE_EXCEPTION, so if it would end throwing
it'd just do nothing AFAIU.

(Deprecating SGTM BTW - there's also a tonne of setFoo (Foo in [Shadow,
FillColor, StrokeColor, ...] which might make sense to try to deprecate too?)

[Justin Novosad, 2014-04-14 15:31:41]

On 2014/04/14 15:00:47, fs wrote:
>
https://codereview.chromium.org/232313004/diff/1/Source/core/html/canvas/Canv...
> File Source/core/html/canvas/CanvasRenderingContext2D.idl (right):
> 
>
https://codereview.chromium.org/232313004/diff/1/Source/core/html/canvas/Canv...
> Source/core/html/canvas/CanvasRenderingContext2D.idl:145: [StrictTypeChecking]
> void drawImageFromRect(HTMLImageElement? image,
> On 2014/04/14 14:29:42, junov wrote:
> > This is API is not even in the spec. We should probably consider deprecating
> it
> > since is is non-orthogonal.  Anyways, why did you chose to make image
nullable
> > in this case?
> 
> I made it nullable so that the behavior would be preserved. 'HTMLImageElement'
> would previously accept null/undefined/HTMLImageElement, and that would be
> equivalent to using a nullable type w/ [StrictTypeChecking]. The
implementation
> just calls drawImageInternal with IGNORE_EXCEPTION, so if it would end
throwing
> it'd just do nothing AFAIU.
> 
> (Deprecating SGTM BTW - there's also a tonne of setFoo (Foo in [Shadow,
> FillColor, StrokeColor, ...] which might make sense to try to deprecate too?)

lgtm

I'll get the deprecations rolling...

[fs, 2014-04-14 15:35:26]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-04-14 15:35:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fs@opera.com/232313004/1

[commit-bot: I haz the power, 2014-04-14 15:46:14]

Change committed as 171477