Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 232313002: ozone: Protect X11-specific code under ash/wm (Closed)

Created:
6 years, 8 months ago by spang
Modified:
6 years, 8 months ago
Reviewers:
varkha
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

ozone: Protect X11-specific code under ash/wm This fixes some build errors for the "chromeos=1 use_ozone=1" build. The touch factory class & ui::CopyAreaToCanvas function are currently only supported under X11. BUG=361341 TEST=chrome --ozone-platform=test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262931

Patch Set 1 #

Total comments: 2

Patch Set 2 : always use defined(USE_X11) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M ash/wm/boot_splash_screen_chromeos.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M ash/wm/system_gesture_event_filter.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
spang
6 years, 8 months ago (2014-04-09 23:41:17 UTC) #1
varkha
https://codereview.chromium.org/232313002/diff/1/ash/wm/boot_splash_screen_chromeos.cc File ash/wm/boot_splash_screen_chromeos.cc (right): https://codereview.chromium.org/232313002/diff/1/ash/wm/boot_splash_screen_chromeos.cc#newcode38 ash/wm/boot_splash_screen_chromeos.cc:38: #if !defined(USE_OZONE) Should this maybe use #if defined(USE_X11) just ...
6 years, 8 months ago (2014-04-09 23:46:52 UTC) #2
spang
https://codereview.chromium.org/232313002/diff/1/ash/wm/boot_splash_screen_chromeos.cc File ash/wm/boot_splash_screen_chromeos.cc (right): https://codereview.chromium.org/232313002/diff/1/ash/wm/boot_splash_screen_chromeos.cc#newcode38 ash/wm/boot_splash_screen_chromeos.cc:38: #if !defined(USE_OZONE) On 2014/04/09 23:46:52, varkha wrote: > Should ...
6 years, 8 months ago (2014-04-10 00:12:03 UTC) #3
varkha
Thanks, lgtm.
6 years, 8 months ago (2014-04-10 00:14:44 UTC) #4
spang
The CQ bit was checked by spang@chromium.org
6 years, 8 months ago (2014-04-10 00:19:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/232313002/20001
6 years, 8 months ago (2014-04-10 00:22:16 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 05:28:13 UTC) #7
Message was sent while issue was closed.
Change committed as 262931

Powered by Google App Engine
This is Rietveld 408576698