Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1543)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 2323123002: Make disable vsync run the renderer independently (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index 4170eb015a85be8cacdf8eb6db9dfa51d67abd81..999e6a77d5a73c524cd440e1349c37a6554f3351 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -162,6 +162,7 @@
#include "third_party/skia/include/core/SkGraphics.h"
#include "ui/base/layout.h"
#include "ui/base/ui_base_switches.h"
+#include "ui/gl/gl_switches.h"
#if defined(OS_ANDROID)
#include <cpu-features.h>
@@ -1594,6 +1595,25 @@ blink::scheduler::RendererScheduler* RenderThreadImpl::GetRendererScheduler() {
std::unique_ptr<cc::BeginFrameSource>
RenderThreadImpl::CreateExternalBeginFrameSource(int routing_id) {
+ const base::CommandLine* cmd = base::CommandLine::ForCurrentProcess();
+ if (cmd->HasSwitch(switches::kDisableGpuVsync)) {
+ std::string display_vsync_string =
+ cmd->GetSwitchValueASCII(switches::kDisableGpuVsync);
+ if (display_vsync_string == "beginframe" || display_vsync_string != "gpu") {
+ // In disable gpu vsync mode, also let the renderer tick as fast as it
+ // can. The top level begin frame source will also be running as a back
+ // to back begin frame source, but using a synthetic begin frame source
+ // here reduces latency when in this mode (at least for frames
+ // starting--it potentially increases it for input on the other hand.)
+ base::SingleThreadTaskRunner* compositor_impl_side_task_runner =
+ compositor_task_runner_ ? compositor_task_runner_.get()
+ : base::ThreadTaskRunnerHandle::Get().get();
+ return base::MakeUnique<cc::BackToBackBeginFrameSource>(
+ base::MakeUnique<cc::DelayBasedTimeSource>(
+ compositor_impl_side_task_runner));
+ }
+ }
+
return base::MakeUnique<CompositorExternalBeginFrameSource>(
compositor_message_filter_.get(), sync_message_filter(), routing_id);
}

Powered by Google App Engine
This is Rietveld 408576698