third_party/WebKit/LayoutTests/imported/wpt/html/dom/elements/global-attributes/dataset.html - Issue 2323113002: Revert "Import wpt@65954a35b4e0a5cee1f4839271ba0e44f187c0a6"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/imported/wpt/html/dom/elements/global-attributes/dataset.html

Issue 2323113002: Revert "Import wpt@65954a35b4e0a5cee1f4839271ba0e44f187c0a6" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/imported/wpt/html/browsers/history/the-location-interface/security_location_0.sub.htm ('k') | third_party/WebKit/LayoutTests/imported/wpt/html/dom/elements/global-attributes/dir_auto-EN-L-expected.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/imported/wpt/html/dom/elements/global-attributes/dataset.html

diff --git a/third_party/WebKit/LayoutTests/imported/wpt/html/dom/elements/global-attributes/dataset.html b/third_party/WebKit/LayoutTests/imported/wpt/html/dom/elements/global-attributes/dataset.html

index a4a16d014d9b6de9c5fa5523a0fc11b801383931..fe3e032d52897e986d4cbe0050a893834dd7db25 100644

--- a/third_party/WebKit/LayoutTests/imported/wpt/html/dom/elements/global-attributes/dataset.html

+++ b/third_party/WebKit/LayoutTests/imported/wpt/html/dom/elements/global-attributes/dataset.html

@@ -1,5 +1,5 @@

<!DOCTYPE html>

-<title>dataset: should exist and work on HTML and SVG elements, but not random elements</title>

+<title>dataset: should return 'undefined' for non-existent properties</title>

@@ -7,9 +7,6 @@

var div = document.createElement("div");

test(function() {

- assert_true(div.dataset instanceof DOMStringMap);

-}, "HTML elements should have a .dataset");

-test(function() {

assert_false("foo" in div.dataset);

assert_equals(div.dataset.foo, undefined);

}, "Should return 'undefined' before setting an attribute")

@@ -28,11 +25,4 @@ test(function() {

assert_false("foo" in div.dataset);

assert_equals(div.dataset.foo, undefined);

}, "Should return 'undefined' after removing an attribute")

-test(function() {

- assert_equals(document.createElementNS("test", "test").dataset, undefined);

-}, "Should not have a .dataset on random elements");

-test(function() {

- var svg = document.createElementNS("http://www.w3.org/2000/svg", "svg")

- assert_true(svg.dataset instanceof DOMStringMap);

-}, "SVG elements should have a .dataset");

</script>